[FlyDSL][AOT] Fix cktile_epilogue_silu AOT arg mismatch on release/v0.1.16.post4 - #4283
Merged
Fangzhou-Ai merged 1 commit intoJul 17, 2026
Merged
Conversation
The silu path in `_precompile_epilogue_to_cache` still passes a runtime
`swiglu_limit` (`float("inf")`) to `launch_silu_and_mul_fq`, but that
launcher no longer takes a runtime swiglu_limit arg -- swiglu_limit is now
a compile-time parameter of `build_silu_and_mul_fq_module`. The extra
positional arg makes FlyDSL AOT fail with "too many positional arguments"
for every `cktile_epilogue_silu` config, aborting the aiter wheel build
(PREBUILD_KERNELS=1).
Drop the stale `float("inf")` so the launch tuple matches the launcher
(swiglu_limit stays compile-time; default 0.0 = no clamp for silu).
Verified: the 12 configs that fail in CI (inter_dim 256..1536, topk 6..9,
gfx950) go from 12 failed -> 12 ok under COMPILE_ONLY with flydsl 0.2.2.
Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
LGTM, wheel compilation succeeded after this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building the aiter wheel on
release/v0.1.16.post4(PREBUILD_KERNELS=1) fails in FlyDSL AOT: everycktile_epilogue_siluconfig (inter_dim 256–1536, topk 6–9, gfx950) fails withtoo many positional arguments, aborting the build (FlyDSL MOE AOT: 12 failed). This blocks vllm-project/vllm#48683 (post3→post4 bump).Cause
This branch's
silu_and_mul_fq.pyuses the compile-time-swiglu_limitdesign (pre-#3767): the kernel/launcher take no runtime swiglu arg (launch_silu_and_mul_fqis 10-arg). But_precompile_epilogue_to_cache's silu branch still passes the runtime-style tuple with a stalefloat("inf")swiglu_limit → 11 args into a 10-arg launcher. (swiglu uses a separate 4-arg launcher, so only silu breaks.)Fix
Drop the stale
float("inf")so the tuple matches the launcher.swiglu_limitstays compile-time (default0.0= no clamp, correct for silu).Test
flydsl==0.2.2,COMPILE_ONLY=1, gfx950 — the 12 CI-failing configs:too many positional arguments)Notes
Release-local consistency fix, not a cherry-pick:
mainuses the newer runtime-swiglu_limitdesign (#3767, for DSV4/gfx1250); this branch predates it. AI assistance was used; the human submitter has reviewed the one-line diff and verification.