[Don't Merge] Isolate MLA failure: CK pre-#7331 (do not merge) - #3246
Closed
DDEle wants to merge 1 commit into
Closed
[Don't Merge] Isolate MLA failure: CK pre-#7331 (do not merge)#3246DDEle wants to merge 1 commit into
DDEle wants to merge 1 commit into
Conversation
Temporary debug branch to isolate the source of MI35X shard 5/2 test_mla_persistent.py failure observed on PR #3150. PR #3150 bumps CK from 33b62ed0 -> 83566edb0 (10 CK PRs incl. #7331). This commit bumps to the immediately preceding commit (4d852e80f = PR #6983), so CI runs the exact same 9 CK PRs as #3150 minus only the FMHA BWD async-prepare changes that #3150 actually depends on. If MLA still fails here, the cause is one of the other 9 CK PRs (or pre-existing flakiness) — proving the failure is unrelated to PR #3150's own changes. Not for merge.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
DDEle
marked this pull request as ready for review
May 18, 2026 08:59
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the composable_kernel submodule to the commit immediately preceding ROCm/rocm-libraries#7331 to help bisect and attribute the observed test_mla_persistent.py failure (MI35X shard 5/2) without introducing any aiter-side code changes.
Changes:
- Updates
3rdparty/composable_kernelsubmodule revision to4d852e80f(pre-#7331) for CI/bisect isolation. - Leaves the rest of the repository identical to
mainto keep the experiment controlled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #3150 sees a
test_mla_persistent.py(shard 5/2 MI35X) failure that's hard to attribute. PR #3150's own aiter code changes only touch FMHA BWD; CK is also bumped from33b62ed0→83566edb0(10 CK PRs including #7331).This draft bumps CK to
4d852e80f(= PR #6983, the commit immediately before #7331) and leaves everything else identical tomain. CI here exercises the same 9 CK PRs as #3150 minus only #7331's FMHA BWD async-prepare changes.Outcome interpretation
Not for merge
Pure CI diagnostic; will be closed once we have the result.