Skip to content

CI: Use build-only-aiter runner to build Triton wheels #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 1 commit into from
Apr 28, 2026
Merged

CI: Use build-only-aiter runner to build Triton wheels #2934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/triton-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
build-triton:
if: ${{ (!github.event.pull_request || github.event.pull_request.draft == false) && (github.event_name != 'pull_request' || github.event.action != 'labeled' || github.event.label.name == 'ci:triton-300x') }}
name: Build Triton Wheel
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now uses the build-only-aiter runner label, but .github/runner-config.yml (runner→GPU mapping used by the dashboards) doesn’t include an entry for build-only-aiter. If the dashboards/validation depend on that file, add build-only-aiter there (with an appropriate non-GPU/unknown mapping) or document why it’s intentionally omitted.

Suggested change
name: Build Triton Wheel
name: Build Triton Wheel
# `build-only-aiter` is intentionally used here for a build-only job; it is not a
# GPU test runner and may therefore be intentionally omitted from GPU dashboard mappings.

Copilot uses AI. Check for mistakes.
runs-on: linux-aiter-mi35x-1
runs-on: build-only-aiter
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching this job to build-only-aiter may break the later docker run invocation because it unconditionally mounts --device=/dev/kfd and adds render/video groups; if the build-only runner doesn’t have ROCm devices/groups, the job will fail early. Consider making the /dev/kfd mount and getent group ... additions conditional (or dropping them entirely for wheel build if not needed) so this job can run on non-GPU build hosts.

Copilot uses AI. Check for mistakes.
needs: [check-signal]
env:
DOCKER_IMAGE: "rocm/pytorch:latest"
Expand Down
Loading