Skip to content

CI: add docker login before ATOM base image pull #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 2 commits into from
Apr 28, 2026
Merged

CI: add docker login before ATOM base image pull #2931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e65385f
CI: add docker login before ATOM base image pull
gyohuangxin Apr 28, 2026
68019fb
CI: simplify ATOM docker login step
gyohuangxin Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/atom-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ jobs:
repository: ${{ env.ATOM_REPOSITORY_URL }}
branch: ${{ env.ATOM_BRANCH }}

- name: Docker login
run: docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }} || true
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid passing the Docker password via -p on the command line (it can leak via process listings) and avoid swallowing login failures with || true. Prefer --password-stdin and gate the step on the secret being set (e.g., similar to .github/workflows/aiter-release.yaml) so fork PRs skip login but trusted runs fail fast if auth is required.

Suggested change
run: docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }} || true
if: (matrix.run_on_pr == true || github.event_name != 'pull_request') && env.DOCKER_PASSWORD != ''
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
run: |
echo "$DOCKER_PASSWORD" | docker login -u rocmshared --password-stdin

Copilot uses AI. Check for mistakes.

- name: Download the ATOM base image
if: matrix.run_on_pr == true || github.event_name != 'pull_request'
run: |
Expand Down
Loading