Skip to content

CI: add standalone OPUS test workflow #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 4 commits into from
Apr 28, 2026
Merged

CI: add standalone OPUS test workflow #2928

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e164955
CI: add standalone OPUS test workflow
gyohuangxin Apr 13, 2026
889730a
CI: log in before starting OPUS test container
gyohuangxin Apr 28, 2026
678b1d7
CI: align OPUS workflow with main
gyohuangxin Apr 28, 2026
5861a87
Merge remote-tracking branch 'origin/main' into xin/opus-test-main
gyohuangxin Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/opus-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}

- name: Docker login
run: docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }} || true
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker login -p ... || true both passes the password on the command line (can leak via process list) and suppresses login failures, which can make image pull issues harder to diagnose. Prefer --password-stdin and gate the step so it only runs when the secret is available (e.g. skip on fork PRs / when DOCKER_PASSWORD is empty) rather than ignoring errors.

Suggested change
run: docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }} || true
if: ${{ secrets.DOCKER_PASSWORD != '' }}
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
run: |
printf '%s\n' "$DOCKER_PASSWORD" | docker login -u rocmshared --password-stdin

Copilot uses AI. Check for mistakes.
- name: Run the container
run: |
set -ex
Expand Down
Loading