Fix precision issue for 32x256 kernel, attempt #3#2587
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
JohnNikolay84
force-pushed
the
precision_issue
branch
from
94ecf1a to
7c6d98b
Compare
nholmber
added a commit
to nholmber/aiter
that referenced
this pull request
Apr 5, 2026
Adds tuned_fmoe.csv (1857 lines, all TP1/TP2/TP4 shapes) and untuned_fmoe.csv from reference image. Updated 76 kernel symbol entries to match renamed symbols from PR ROCm#2587 precision fix.
nholmber
added a commit
to nholmber/aiter
that referenced
this pull request
Apr 5, 2026
PR ROCm#2587 renamed kernel symbols in the silu blockscale CSV: - fmoe_bf16_blockscaleFp8_g1u1_silu_64x256 -> vs_ps_silu_64x256 - fmoe_bf16_blockscaleFp8_g1u1_silu_64x128 -> vs_ps_silu_64x128 Updated 38 references in tuned_fmoe.csv to match.
Contributor
Author
|
@valarLip do you have any objections about this commit ? Should I run more tests ? |
valarLip
approved these changes
Apr 9, 2026
sunway513
pushed a commit
that referenced
this pull request
Apr 21, 2026
ClementLinCF
pushed a commit
that referenced
this pull request
Apr 25, 2026
Liang-jianhao97
pushed a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix precision issue for asm fmoe kernels.
Technical Details
cl_gemm0_withup wait counters are not being used correctly.
Test Plan
DeepSeek model accuracy is 95%
local 2 stage fmoe unit test show ~50% matching values and max diff should be 40% less than before.
Test Result
DS:
Submission Checklist