Skip to content

assert when found duplicated shape#2503

Merged
valarLip merged 20 commits intomainfrom
reapply-pr-2376
Apr 1, 2026
Merged

assert when found duplicated shape#2503
valarLip merged 20 commits intomainfrom
reapply-pr-2376

Conversation

@yzhou103
Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@yzhou103 yzhou103 requested review from a team and Copilot March 27, 2026 07:11
@github-actions
Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-355 Run Triton tests on MI355 in addition to MI325
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2503 --add-label <label>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Tightens config CSV merging in aiter/jit/core.py to detect duplicated shapes during merges (instead of silently dropping them) and adds/updates model-specific tuned/untuned config CSVs to avoid duplicate-shape collisions.

Changes:

  • Reworks update_config_files() to validate column compatibility across merged CSVs and to error out when duplicate shapes are found (with an attempted auto-resolution path).
  • Adds new model config CSVs (kimik2/gptoss/dsv3/qwen) for untuned/tuned GEMM and FP4 FMoE shapes.
  • Removes specific duplicate entries from existing tuned GEMM CSVs.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
aiter/jit/core.py Changes merge logic and duplicate-shape handling when combining multiple config CSVs.
aiter/configs/model_configs/kimik2_fp4_untuned_fmoe.csv Adds untuned FP4 FMoE shapes for kimik2.
aiter/configs/model_configs/kimik2_bf16_untuned_gemm.csv Adds untuned BF16 GEMM shapes for kimik2.
aiter/configs/model_configs/kimik2_bf16_tuned_gemm.csv Removes a duplicate tuned entry.
aiter/configs/model_configs/gptoss_bf16_untuned_gemm.csv Adds untuned BF16 GEMM shapes for gptoss.
aiter/configs/model_configs/dsv3_fp4_untuned_fmoe.csv Adds untuned FP4 FMoE shapes for dsv3.
aiter/configs/model_configs/dsv3_bf16_untuned_gemm.csv Adds untuned BF16 GEMM shapes for dsv3.
aiter/configs/model_configs/dsv3_bf16_tuned_gemm.csv Removes duplicate tuned entries.
aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_untuned_gemm_qwen3_235b.csv Adds untuned A8W8 blockscale+bpreshuffle GEMM shapes for qwen3 235b.
aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_untuned_gemm_qwen3.5_397b.csv Adds untuned A8W8 blockscale+bpreshuffle GEMM shapes for qwen3.5 397b.
aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_untuned_gemm_dsv3.csv Adds untuned A8W8 blockscale+bpreshuffle GEMM shapes for dsv3.
aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_tuned_gemm_qwen3_235b.csv Removes duplicate tuned entries for qwen3 235b.
aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_tuned_gemm_qwen3.5_397b.csv Removes duplicate tuned entries for qwen3.5 397b.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread aiter/jit/core.py
Comment thread aiter/jit/core.py
Comment thread aiter/configs/model_configs/dsv3_bf16_untuned_gemm.csv Outdated
valarLip and others added 15 commits March 28, 2026 13:10
Keep PR #2503 focused on duplicate-shape handling in aiter/jit/core.py and model-config CSV updates by reverting unintentionally included fused_qk/allreduce/test changes.

Made-with: Cursor
Keep the PR scope limited to aiter/jit/core.py and model config CSV changes by removing the remaining communication and multigpu test file deltas.

Made-with: Cursor
Drop remaining non-core, non-csv diffs introduced by hook normalization so the PR scope stays limited to aiter/jit/core.py and model config CSV changes.

Made-with: Cursor
@valarLip valarLip merged commit 94a6edd into main Apr 1, 2026
25 checks passed
@valarLip valarLip deleted the reapply-pr-2376 branch April 1, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants