Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens config CSV merging in aiter/jit/core.py to detect duplicated shapes during merges (instead of silently dropping them) and adds/updates model-specific tuned/untuned config CSVs to avoid duplicate-shape collisions.
Changes:
- Reworks
update_config_files()to validate column compatibility across merged CSVs and to error out when duplicate shapes are found (with an attempted auto-resolution path). - Adds new model config CSVs (kimik2/gptoss/dsv3/qwen) for untuned/tuned GEMM and FP4 FMoE shapes.
- Removes specific duplicate entries from existing tuned GEMM CSVs.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| aiter/jit/core.py | Changes merge logic and duplicate-shape handling when combining multiple config CSVs. |
| aiter/configs/model_configs/kimik2_fp4_untuned_fmoe.csv | Adds untuned FP4 FMoE shapes for kimik2. |
| aiter/configs/model_configs/kimik2_bf16_untuned_gemm.csv | Adds untuned BF16 GEMM shapes for kimik2. |
| aiter/configs/model_configs/kimik2_bf16_tuned_gemm.csv | Removes a duplicate tuned entry. |
| aiter/configs/model_configs/gptoss_bf16_untuned_gemm.csv | Adds untuned BF16 GEMM shapes for gptoss. |
| aiter/configs/model_configs/dsv3_fp4_untuned_fmoe.csv | Adds untuned FP4 FMoE shapes for dsv3. |
| aiter/configs/model_configs/dsv3_bf16_untuned_gemm.csv | Adds untuned BF16 GEMM shapes for dsv3. |
| aiter/configs/model_configs/dsv3_bf16_tuned_gemm.csv | Removes duplicate tuned entries. |
| aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_untuned_gemm_qwen3_235b.csv | Adds untuned A8W8 blockscale+bpreshuffle GEMM shapes for qwen3 235b. |
| aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_untuned_gemm_qwen3.5_397b.csv | Adds untuned A8W8 blockscale+bpreshuffle GEMM shapes for qwen3.5 397b. |
| aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_untuned_gemm_dsv3.csv | Adds untuned A8W8 blockscale+bpreshuffle GEMM shapes for dsv3. |
| aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_tuned_gemm_qwen3_235b.csv | Removes duplicate tuned entries for qwen3 235b. |
| aiter/configs/model_configs/a8w8_blockscale_bpreshuffle_tuned_gemm_qwen3.5_397b.csv | Removes duplicate tuned entries for qwen3.5 397b. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Keep PR #2503 focused on duplicate-shape handling in aiter/jit/core.py and model-config CSV updates by reverting unintentionally included fused_qk/allreduce/test changes. Made-with: Cursor
Keep the PR scope limited to aiter/jit/core.py and model config CSV changes by removing the remaining communication and multigpu test file deltas. Made-with: Cursor
Drop remaining non-core, non-csv diffs introduced by hook normalization so the PR scope stays limited to aiter/jit/core.py and model config CSV changes. Made-with: Cursor
valarLip
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist