opt_unit_test - #1867
Merged
Merged
opt_unit_test#1867
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors three GEMM operation test files to improve code organization and maintainability. The changes move hardcoded test configurations into argparse defaults and simplify argument processing logic.
Changes:
- Improved code style by adding proper spacing around division operators in f-strings
- Refactored argument parser setup to use defaults directly instead of post-processing arguments with conditional logic
- Removed hardcoded test configuration lists from global scope and moved them into argparse default values
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| op_tests/test_gemm_a8w8_blockscale_mi350.py | Added spacing around operators; refactored argument parser to use defaults and removed manual argument processing logic |
| op_tests/test_gemm_a8w8_blockscale.py | Refactored argument parser with proper type converters and defaults; removed hardcoded configuration lists and manual processing |
| op_tests/test_gemm_a4w4.py | Refactored argument parser to use defaults directly; removed hardcoded MNK shape list and manual processing logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valarLip
reviewed
Jan 19, 2026
junhaha666
approved these changes
Jan 20, 2026
yzhou103
pushed a commit
that referenced
this pull request
Jan 28, 2026
* opt_unit_test * remove test_gemm_a8w8_blockscale_mi350.py
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
* opt_unit_test * remove test_gemm_a8w8_blockscale_mi350.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist