Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issues with FP4 (4-bit floating point) instance generation for MoE (Mixture of Experts) GEMM operations by adding architecture-aware build filtering to prevent generating FP4 code for unsupported GPU architectures.
Key Changes:
- Added arch-aware filtering to skip FP4 instance generation unless gfx950 GPU architecture is targeted
- Wrapped FP4 instances with preprocessor directives (
#if defined(__gfx950__)) for compile-time filtering - Fixed typo: renamed variable from
intsancetobody
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amd-ruitang3
reviewed
Jan 6, 2026
Collaborator
|
@zufayu ci failed |
valarLip
approved these changes
Jan 12, 2026
zhuyuhua-v
pushed a commit
that referenced
this pull request
Jan 14, 2026
* bug fix * fix flag * update --------- Co-authored-by: zufayu <zufayu@amd.com> Co-authored-by: lalala-sh <Jiaxing.Wen@amd.com>
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
* bug fix * fix flag * update --------- Co-authored-by: zufayu <zufayu@amd.com> Co-authored-by: lalala-sh <Jiaxing.Wen@amd.com>
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
* bug fix * fix flag * update --------- Co-authored-by: zufayu <zufayu@amd.com> Co-authored-by: lalala-sh <Jiaxing.Wen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist