[fix] correct return type of fused arnorm fake impl#1502
Merged
Conversation
Signed-off-by: root <root@hjbog-srdc-24.amd.com>
Signed-off-by: root <root@hjbog-srdc-24.amd.com>
1 task
farlukas
pushed a commit
that referenced
this pull request
Dec 4, 2025
* [fix]: fused_ar_rms acc error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * [fix]: reduce_scatter boundary check error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * correct return type of fused_arnorm fake impl --------- Signed-off-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: guanbao <gyu@amd.com>
nsusanto
pushed a commit
that referenced
this pull request
Dec 4, 2025
* [fix]: fused_ar_rms acc error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * [fix]: reduce_scatter boundary check error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * correct return type of fused_arnorm fake impl --------- Signed-off-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: guanbao <gyu@amd.com>
zhuyuhua-v
pushed a commit
that referenced
this pull request
Dec 17, 2025
* [fix]: fused_ar_rms acc error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * [fix]: reduce_scatter boundary check error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * correct return type of fused_arnorm fake impl --------- Signed-off-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: guanbao <gyu@amd.com>
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
* [fix]: fused_ar_rms acc error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * [fix]: reduce_scatter boundary check error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * correct return type of fused_arnorm fake impl --------- Signed-off-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: guanbao <gyu@amd.com>
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
* [fix]: fused_ar_rms acc error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * [fix]: reduce_scatter boundary check error Signed-off-by: root <root@hjbog-srdc-24.amd.com> * correct return type of fused_arnorm fake impl --------- Signed-off-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: root <root@hjbog-srdc-24.amd.com> Co-authored-by: guanbao <gyu@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Correct the return type of arnorm fake impl to a tuple, otherwise we will see dynamo error during torch.compile model using this custom fusion kernel:
Test Plan
Test it with deepseek in ATOM.
Test Result
It can be compiled without error and run normally.
Submission Checklist