Skip to content

CI: Move some tests to MI355 due to the network issue of TW cluster #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 3 commits into from
Nov 20, 2025
Merged

CI: Move some tests to MI355 due to the network issue of TW cluster #1446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
239e1c3
CI: Move some tests to MI355 due to the network issue of TW cluster
gyohuangxin Nov 20, 2025
90d5cc9
Modify the GPU_ARCH of sglang tests
gyohuangxin Nov 20, 2025
82005b4
Docker login
gyohuangxin Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/aiter-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,16 @@ jobs:
pr_title="${{ github.event.pull_request.title }}"
if [[ "${{ github.ref }}" == "refs/heads/main" ]]; then
echo "It's main branch, running tests on MI325 and MI35X..."
echo 'standard_runners=["aiter-1gpu-runner","aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner","aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
Comment on lines 44 to +46
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo message says 'running tests on MI325 and MI35X...' but the code only configures MI355 runners. The message should be updated to reflect that tests now run only on MI35X/MI355.

Copilot uses AI. Check for mistakes.
elif echo "$pr_title" | grep -qi "mi35x"; then
echo "PR title contains 'MI35X', running tests on MI325 and MI35X..."
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
Comment on lines 48 to +50
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo message says 'running tests on MI325 and MI35X...' but the code only configures MI355 runners. The message should be updated to reflect that tests now run only on MI35X/MI355.

Copilot uses AI. Check for mistakes.
else
echo "Not main branch and PR title does not contain mi35x, only running on MI325..."
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo message says 'only running on MI325...' but the code configures MI355 runners instead. The message should be updated to reflect that tests now run on MI355.

Suggested change
echo "Not main branch and PR title does not contain mi35x, only running on MI325..."
echo "Not main branch and PR title does not contain mi35x, only running on MI355..."

Copilot uses AI. Check for mistakes.
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
fi
echo "$GITHUB_OUTPUT"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sglang_downstream.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
sglang:
name: sglang integration
needs: [check-signal]
runs-on: aiter-1gpu-runner
runs-on: aiter-mi355-1gpu
env:
SGL_BRANCH: v0.5.3
GPU_ARCH: gfx942
GPU_ARCH: gfx950
SGL_IMAGE: rocm/sgl-dev:v0.5.3.post3-rocm700-mi30x-20251019
GITHUB_REPO_URL: ${{ github.event.pull_request.head.repo.clone_url || 'https://github.com/ROCm/aiter.git' }}
GITHUB_COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.event.head_commit.id }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vllm_benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
build_vllm_image:
if: ${{ !github.event.pull_request.head.repo.fork }}
needs: [check-signal]
runs-on: aiter-1gpu-runner
runs-on: aiter-k8s-build

steps:
- name: Checkout aiter repo
Expand Down
Loading