Skip to content

Temporarily disable the test on mi355 #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 1 commit into from
Nov 19, 2025
Merged

Temporarily disable the test on mi355 #1437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/aiter-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,16 @@ jobs:
pr_title="${{ github.event.pull_request.title }}"
if [[ "${{ github.ref }}" == "refs/heads/main" ]]; then
echo "It's main branch, running tests on MI325 and MI35X..."
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo message claims "running tests on MI325 and MI35X..." but the updated runner configuration only includes MI325 runners (aiter-1gpu-runner). This creates misleading log output. Consider updating the message to reflect that only MI325 tests are running, e.g., "It's main branch, running tests on MI325 only..."

Suggested change
echo "It's main branch, running tests on MI325 and MI35X..."
echo "It's main branch, running tests on MI325 only..."

Copilot uses AI. Check for mistakes.
echo 'standard_runners=["aiter-1gpu-runner","aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner","aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
elif echo "$pr_title" | grep -qi "mi35x"; then
echo "PR title contains 'MI35X', running tests on MI325 and MI35X..."
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo message claims "running tests on MI325 and MI35X..." but the updated runner configuration only includes MI325 runners (aiter-1gpu-runner). This creates misleading log output. Consider updating the message to reflect that only MI325 tests are running, e.g., "PR title contains 'MI35X', but running tests on MI325 only..."

Suggested change
echo "PR title contains 'MI35X', running tests on MI325 and MI35X..."
echo "PR title contains 'MI35X', but running tests on MI325 only..."

Copilot uses AI. Check for mistakes.
echo 'standard_runners=["aiter-1gpu-runner","aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner","aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
else
echo "Not main branch and PR title does not contain mi35x, only running on MI325..."
echo 'standard_runners=["aiter-1gpu-runner","aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner","aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
fi
echo "$GITHUB_OUTPUT"

Expand Down
Loading