Repository navigation
[Triton] DS FP4 fusions redo - #1434
Merged
Merged
Conversation
Collaborator
|
@kkHuang-amd let me know if it works for you |
k50112113
force-pushed
the
shaoclee/ds_fp4_triton_fusion_redo
branch
from
November 20, 2025 15:42
9f034d2 to
6503284
Compare
…fp4_triton_fusion_redo
1 task
lucas-santos-amd
approved these changes
Dec 3, 2025
zhuyuhua-v
pushed a commit
that referenced
this pull request
Dec 17, 2025
* add kernel and integration in fused_moe, add UT * add fused_gemm_afp4wfp4_a16w16.py * fix bug * add fused_reduce_act_mul_and_mxfp4_quant * add gemm_a16wfp4.py * fix * fix * fix * clean up * repr * update AOT with repr * fix bug * add dummy heuristics * add output_unquantized_inp1 to fused_rms_mxfp4_quant * add configs * fix bug, tune fused_reduce_act_mul_and_mxfp4_quant * fix * fix * final clean up * add batched_gemm_a16wfp4 * clean up * add config * add default config * remove old kernels, add API redirection and deprecation warning * add fused_gemm_afp4wfp4_mul_add * remove * fp4 gemm config, add fsued_reduce_rms_fp4_quant * ut fix black formatting * fix * black formatting * Retuning for DS FP4 batched gemm and o_proj performance * add fused_gemm_afp4wfp4_split_cat --------- Co-authored-by: amirumoAMD <Amelia.Moore@amd.com> Co-authored-by: Lingpeng Jin <103567126+valarLip@users.noreply.github.com>
valarLip
added a commit
that referenced
this pull request
Mar 18, 2026
* add kernel and integration in fused_moe, add UT * add fused_gemm_afp4wfp4_a16w16.py * fix bug * add fused_reduce_act_mul_and_mxfp4_quant * add gemm_a16wfp4.py * fix * fix * fix * clean up * repr * update AOT with repr * fix bug * add dummy heuristics * add output_unquantized_inp1 to fused_rms_mxfp4_quant * add configs * fix bug, tune fused_reduce_act_mul_and_mxfp4_quant * fix * fix * final clean up * add batched_gemm_a16wfp4 * clean up * add config * add default config * remove old kernels, add API redirection and deprecation warning * add fused_gemm_afp4wfp4_mul_add * remove * fp4 gemm config, add fsued_reduce_rms_fp4_quant * ut fix black formatting * fix * black formatting * Retuning for DS FP4 batched gemm and o_proj performance * add fused_gemm_afp4wfp4_split_cat --------- Co-authored-by: amirumoAMD <Amelia.Moore@amd.com> Co-authored-by: Lingpeng Jin <103567126+valarLip@users.noreply.github.com>
azaidy
pushed a commit
that referenced
this pull request
Oct 5, 2026
The benchmark cannot run: it imports generate_gemm_afp4wfp4_pre_quant_inputs from op_tests.triton_tests.gemm.basic.test_gemm_afp4wfp4_pre_quant_atomic, a module that no longer exists. The DS FP4 fusion work (#1371, #1434) renamed that test to test_gemm_a16wfp4.py, so every run fails with ModuleNotFoundError. #2601 tried to restore the helper. It was closed because gemm_afp4wfp4_pre_quant is a deprecated wrapper, superseded by gemm_a16wfp4 and slated for removal, and the bench should be deleted. This does that, and drops the bench's entry from bench_schema.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.