Skip to content

Temporarily run aiter standard and multigpu tests on the TW cluster, will switch back once the mirror registry is ready. #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 1 commit into from
Nov 7, 2025
Merged

Temporarily run aiter standard and multigpu tests on the TW cluster, will switch back once the mirror registry is ready. #1359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/aiter-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,16 @@ jobs:
pr_title="${{ github.event.pull_request.title }}"
if [[ "${{ github.ref }}" == "refs/heads/main" ]]; then
echo "It's main branch, running tests on MI300 and MI35X..."
echo 'standard_runners=["aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
elif echo "$pr_title" | grep -qi "mi35x"; then
echo "PR title contains 'MI35X', running tests on MI300 and MI35X..."
echo 'standard_runners=["aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
else
echo "Not main branch and PR title does not contain mi35x, only running on MI300..."
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'only running on MI300...' is now misleading after the runner name change. The new generic runner names 'aiter-1gpu-runner' and 'aiter-8gpu-runner' don't specifically indicate MI300 hardware. Consider updating the comment to reflect the actual behavior, such as 'only running on standard runners...' or remove the hardware-specific reference.

Suggested change
echo "Not main branch and PR title does not contain mi35x, only running on MI300..."
echo "Not main branch and PR title does not contain mi35x, only running on standard runners..."

Copilot uses AI. Check for mistakes.
echo 'standard_runners=["aiter-mi355-1gpu"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-mi355-8gpu"]' >> "$GITHUB_OUTPUT"
echo 'standard_runners=["aiter-1gpu-runner"]' >> "$GITHUB_OUTPUT"
echo 'multigpu_runners=["aiter-8gpu-runner"]' >> "$GITHUB_OUTPUT"
fi
echo "$GITHUB_OUTPUT"

Expand Down
Loading