-
Notifications
You must be signed in to change notification settings - Fork 266
Kernel naming: add reusable constexpr repr helper and testing it with gemm_a16w16 #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f4f95ec
Kernel naming: add reusable constexpr repr helper
Boss2002n c61b5ee
add missing params to the repr
Boss2002n 7e22835
Merge branch 'main' into amd/satya/kernel_config_to_name
Boss2002n 2519d00
Merge branch 'main' into amd/satya/kernel_config_to_name
Boss2002n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| def _sanitize_constexpr_value(value): | ||
| if value is None: | ||
| return "NONE" | ||
| if isinstance(value, bool): | ||
| return str(int(value)) | ||
| if isinstance(value, int): | ||
| return str(value) | ||
| if isinstance(value, float): | ||
| if value.is_integer(): | ||
| return str(int(value)) | ||
| return str(value) | ||
|
|
||
| # for lists, tuples, sets - recursively join each | ||
| if isinstance(value, (list, tuple, set)): | ||
| items = sorted(value, key=str) if isinstance(value, set) else value | ||
| sanitized_items = [_sanitize_constexpr_value(item) for item in items] | ||
| joined = "_".join(sanitized_items) | ||
| return joined if joined else "NONE" | ||
|
|
||
| if isinstance(value, str): | ||
| cleaned_value = "".join(ch if ch.isalnum() else "_" for ch in value).strip("_") | ||
| return cleaned_value.upper() if cleaned_value else "NONE" | ||
|
|
||
| cleaned_value = "".join(ch if ch.isalnum() else "_" for ch in str(value)).strip("_") | ||
| return cleaned_value.upper() if cleaned_value else "NONE" | ||
|
|
||
|
|
||
| def make_kernel_repr(base_name, config_keys): | ||
| def _repr(specialization): | ||
| constants = specialization.constants | ||
| name_parts = [] | ||
|
|
||
| for key in config_keys: | ||
| value = constants.get(key, None) | ||
| symbol = _sanitize_constexpr_value(value) | ||
| name_parts.append(f"{key}_{symbol}") | ||
|
|
||
| if not name_parts: | ||
| return base_name | ||
|
|
||
| suffix = "_".join(name_parts) | ||
| return f"{base_name}_{suffix}" | ||
|
|
||
| return _repr |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.