Skip to content

Conversation

@AllenFarcas
Copy link
Contributor

@AllenFarcas AllenFarcas commented Oct 6, 2025

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes https://github.com/ROCm/frameworks-internal/issues/13667

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Added guards for getDeviceComputeCapability() which is for NVIDIA platforms
  • Implementedfp8_quantize_rocm reusing CastVectorizedUnaryKernelLauncher and CastVectorizedUnaryGradKernelLauncher
  • Implemented partial_reduce_kernel and reduce_dbias_rocm to efficiently reduce large sized inputs
  • Enabled test_cast_dbias and test_cast_dbias_dgelu cpp tests for ROCm

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@alextmagro alextmagro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM, just need to move some functions to rocm_cast_kernels.cuh for licensing. Great work!

@AllenFarcas AllenFarcas requested a review from wangye805 October 27, 2025 16:27
@AllenFarcas AllenFarcas force-pushed the alfarcas/issue13667-fix branch from 819ec5c to 56b9dce Compare November 3, 2025 18:15
@AllenFarcas AllenFarcas force-pushed the alfarcas/issue13667-fix branch from 56b9dce to b893a87 Compare November 7, 2025 18:12
Copy link
Collaborator

@wenchenvincent wenchenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllenFarcas There are some core sgpu test failures. Could you make sure that they're fixed?

@AllenFarcas AllenFarcas requested a review from ipanfilo November 14, 2025 16:42
Copy link
Collaborator

@wenchenvincent wenchenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AllenFarcas AllenFarcas merged commit 653b5b4 into dev Nov 19, 2025
6 checks passed
@AllenFarcas AllenFarcas deleted the alfarcas/issue13667-fix branch November 19, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants