Skip to content

[windows] Convert symlinks to hardlinks during tarfile expansion. #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScottTodd merged 1 commit into from
Jul 10, 2025
Merged

[windows] Convert symlinks to hardlinks during tarfile expansion. #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions build_tools/packaging/python/templates/rocm/src/rocm_sdk/_devel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
from . import _dist_info as di


def _is_windows():
return platform.system() == "Windows"


def get_devel_root() -> Path:
try:
import rocm_sdk_devel
Expand Down Expand Up @@ -159,6 +163,16 @@ def _clean_dir(dir: Path):
# hash (empty)
# size (empty)
record_file.write(f"{ti.name},,\n")
if _is_windows() and ti.issym():
# Convert symlinks into hardlinks on Windows.
# This saves disk space while improving compatibility
# on systems without as robust symlink support.
# As needed, we could also generate tarfiles with
# copies instead of symlinks, at the cost of disk space.
symlink_target = dest_path.readlink()
hardlink_target = dest_path.parent / symlink_target
dest_path.unlink()
dest_path.hardlink_to(hardlink_target)
elif ti.isdir():
# We don't generally have directory entries, but handle
# them if we do.
Expand All @@ -170,10 +184,6 @@ def _clean_dir(dir: Path):
file_lock.unlock()


def _is_windows():
return platform.system() == "Windows"


class FileLock:
"""Small portability shim between fcntl.lockf and msvcrt.locking for our uses."""

Expand Down