Repository navigation
Conversation
2 of 3 tasks
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
|
I don't think this is correct. The only thing the parallel invocation does at the moment is parallel compilation, which means we speed things up by pre-compiling everything. Tests are still run serially, one by one. Could you please clarify what problem you ran into? |
lumachad
requested changes
Nov 2, 2026
lumachad
left a comment
Contributor
There was a problem hiding this comment.
This looks incorrect. Let's discuss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope clarification
This is not a Python 3.15 or shared-libpython failure. The failure came from TheRock #8394 CI, where the ROCgdb GPU job used Python 3.12.16 and the ROCgdb-specific
no_rocm_image_ubuntu24_04_rocgdbtest container.The manylinux/Python 3.15 image is a separate, completed dependency: TheRock #9633 published digest
sha256:f1f9dd9b..., verified with regular CPython 3.15.2 and shared CPython 3.15.0. #9688 does not modify that image or its shared libpython build.Observed failure
The gfx94X ROCgdb test job ran:
It produced widespread GPU-debug failures, including multi-inferior stress at 8/32 inferiors, stepping/fork/attach tests, and a 30-minute timeout. Cleanup found 33 lingering ROCgdb/GPU test processes.
Proposed change
At the ROCgdb revision pinned by TheRock (
003062db3),--parallelsetsFORCE_PARALLEL=1, selecting Make'scheck-paralleltarget. This PR tests serializing that GPU suite and extending its job timeout; it is a runner/test-stability fix, not Python enablement.Lumachad correctly requested clarification because the behavior should be reconciled with the current test-runner implementation before merging. This PR remains draft while that review is resolved.
Validation
fetch_test_configurations_test: 107 tests passed.git diff --checkpassed.Tracked in AIPYTORCH-1241.