Skip to content

fix(cmake): propagate debug-info flags to native HIP targets - #9681

Merged
amd-chiranjeevi merged 1 commit into
mainfrom
users/amd-chiranjeevi/asan-debug-fix
Nov 2, 2026
Merged

amd-chiranjeevi merged 1 commit into
mainfrom
users/amd-chiranjeevi/asan-debug-fix

Conversation

@amd-chiranjeevi

@amd-chiranjeevi amd-chiranjeevi commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The ASAN nightly fails to build amdrocm-profiler-base-asan10.3 because Debian’s dwz rejects debug information in roctracer test binaries:

      dwz: .../share/roctracer/test/MatrixTranspose:
           Unknown debugging section .debug_str_offsets

The failure appeared after ROCm/rocm-systems#5708 migrated roctracer tests from legacy hip_add_executable() to native CMake HIP targets. TheRock picked up that migration through #9592.

Failing log: https://github.com/ROCm/rockrel/actions/runs/41149061756/job/124415390789

GitHub issue: #9676, ROCM-33804

Test Result

Submission Checklist

@amd-chiranjeevi amd-chiranjeevi added the ci:asan-debug Opt-in to full ASan builds with debug information label Nov 2, 2026
@therock-pr-bot

therock-pr-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@amd-chiranjeevi amd-chiranjeevi added ci:asan Opt-in to building ASAN and removed ci:asan-debug Opt-in to full ASan builds with debug information labels Nov 2, 2026
@amd-chiranjeevi
amd-chiranjeevi marked this pull request as ready for review November 2, 2026 08:50

@nunnikri nunnikri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amd-chiranjeevi

Copy link
Copy Markdown
Contributor Author

failures are unrelated to this change
build msi failure issue - #9650

@amd-chiranjeevi
amd-chiranjeevi merged commit 63204ba into main Nov 2, 2026
353 of 372 checks passed
@amd-chiranjeevi
amd-chiranjeevi deleted the users/amd-chiranjeevi/asan-debug-fix branch November 2, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:asan Opt-in to building ASAN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants