Repository navigation
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
|
Need to wait for rocm-libraries bump to include ROCm/rocm-libraries#14423, then will rebase. |
#9626 merged. Pulling it in and re-running tests. |
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
I can review in more depth later in the week. Initial comments...
There was a problem hiding this comment.
Let's figure out how this fits in with existing tests for CMake projects produced by artifacts/packages.
- https://github.com/ROCm/TheRock/blob/main/examples/cpp-sdk-user/CMakeLists.txt
- https://github.com/ROCm/TheRock/blob/main/build_tools/packaging/linux/tests/downstream_cmake_smoke_test.py (recently added for Add a downstream find_package() CMake smoke test to install CI #9056, though I suggested it should use
examples/cpp-sdk-user- what's the plan @nunnikri / @arvindcheru ?)
See also:
- https://github.com/ROCm/TheRock/blob/main/TESTING.md#packaging---validation-methods
- Add component tests that use Python and native packages #5384
My preference would be to have a standard way for each of the 30+ subprojects to tests their install, and this is a lot of code specific to rocwmma. Let's see why the existing tests missed this.
There was a problem hiding this comment.
Would you recommend moving the cmake rocwmma consumer tests from rocm-libraries to TheRock (under cpp-sdk-user somewhere?). Another alternative is perhaps having cpp-sdk-user tests find tests from the pinned rocm-libraries submodule?
Looking forward to hearing your thoughts/preferences!
Motivation
Due to changes in the rocWMMA CMake configuration, our handing of OpenMP changed, causing breaks in the downstream rocm-examples project's rocWNMA tests when running on Windows.
ROCm/rocm-libraries#14423 adds some post-install tests for rocWMMA on the libraries side. This PR runs those tests as part of the CI flow.
See:
JIRA ID: ROCM-33266
Technical Details
This change picks up rocWMMA's new projects/rocwmma/test/cmake/package_consumer/tests.json file, which specifies a list of post-install tests to run that will consume the rocwmma.cmake package.
Test Plan
CI
Test Result
Submission Checklist