Repository navigation
fix(ci): list PR files when the compare API truncates - #9508
Open
vedithal-amd wants to merge 2 commits into
Open
vedithal-amd wants to merge 2 commits into
vedithal-amd wants to merge 2 commits into
Conversation
The compare API returns at most 300 files, so larger PRs to external repos ran every test. When it truncates on a pull_request event, read the PR number from the event payload and list the files with the PR files endpoint, which returns up to 3000. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved revision matching, caller permissions, and package-import failures can skip required tests or prevent CI configuration.
4 open issues
What changed in this PR
This PR addresses #9507 by extending TheRock’s external-repository CI selection to handle large pull requests without immediately selecting every project.
Changes:
- Falls back to the paginated PR-files endpoint when the compare API reaches its 300-file limit.
- Reads the PR number from the event payload and retains the run-all fallback at 3,000 files.
- Adds fallback-routing coverage and isolates the existing truncation test from event payloads.
| File | Description |
|---|---|
build_tools/tests/configure_external_repo_ci_test.py |
Tests fallback routing and mocks event-derived PR detection. |
build_tools/github_actions/configure_external_repo_ci.py |
Adds PR-number loading and paginated changed-file retrieval. |
Review effort: Balanced
| TypeVar, | ||
| ) | ||
|
|
||
| from github_actions_api import gha_load_github_event |
| pr_number = get_event_pr_number() if modified_paths is None else None | ||
| if pr_number: | ||
| logger.info(f"Getting PR #{pr_number} files via API") | ||
| modified_paths = get_pr_modified_paths_api(github_repo, pr_number) |
| pr_number = get_event_pr_number() if modified_paths is None else None | ||
| if pr_number: | ||
| logger.info(f"Getting PR #{pr_number} files via API") | ||
| modified_paths = get_pr_modified_paths_api(github_repo, pr_number) |
Comment on lines
+288
to
+290
| @patch("configure_external_repo_ci.get_pr_modified_paths_api") | ||
| @patch("configure_external_repo_ci.get_event_pr_number", return_value=123) | ||
| @patch("configure_external_repo_ci.get_modified_paths_api", return_value=None) |
This was referenced Oct 26, 2026
Contributor
Author
|
Hi @lamikr - do you think this PR will help with the issue assigned to you #9447 - if not i will close it - if yes could you please provide review - thanks! I had originally created this PR to prevent rocprofiler-compute sprint prs from running unnecessary builds and tests due to workflow not able to figure out which component changed when more than 300 files changed |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the 300-file truncation in #9447.
configure_external_repo_ci.pygets a PR's changed files from the compare API, which returns at most 300 files. At 300 or more, it can't tell which projects changed and runs every test. Large PRs that touch one project, like rocprofiler-compute sprint drops in rocm-systems, build and test every project and fail on unrelated timeouts.Technical Details
pull_requestevent, read the PR number from the event payload withgha_load_github_event()and list the files with the PR files endpoint, which returns up to 3000.build_tools/github_actions, so the new import resolves.Test Plan
configure_external_repo_ci.py, also run withGITHUB_EVENT_PATHset to a fake PR event to confirm no test calls the real API.pre-commit runon the changed files.main.Test Result
Unit tests and pre-commit pass locally. On this branch the script reports only
projects/rocprofiler-computeas changed. Onmainit falls back to running all tests.Submission Checklist
🤖 Generated with Claude Code