[ronlieb]

Enable fast hostcalls for device-libs and clr using the
option(THEROCK_USE_NEW_HOSTCALL_IMPL "Use the new phase/occupancy-based hostcall implementation in device-libs and clr" ON)

Land this after 10.2 snaps

Reenable fast hostcalls :
Reverts #9021

JIRA ID : https://amd-hub.atlassian.net/browse/ROCM-32952

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: build_tools/setup_ccache.py; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[searlmc1]

LGTM

[lancesix]

Hi,

The current implementation is known to break tools on some platforms. As far as I know, there is a proposed fix in CLR (not merged yet: ROCm/rocm-systems#13665). I expect re-enabling the new host-call without the fix will inevitably lead to regressions.

[ronlieb]

Hi,

The current implementation is known to break tools on some platforms. As far as I know, there is a proposed fix in CLR (not merged yet: ROCm/rocm-systems#13665). I expect re-enabling the new host-call without the fix will inevitably lead to regressions.

i see 13665 is approved and is rerunning CI now. i will start a revert of this feature enable (9432), and we will have a horse race.
1st one to land , wins the day.

[ronlieb]

expectation: the bump delay , will mean we have to revert hostcall, and wait for 13665 to be officially in the rock

[lancesix]

Hi,
The current implementation is known to break tools on some platforms. As far as I know, there is a proposed fix in CLR (not merged yet: ROCm/rocm-systems#13665). I expect re-enabling the new host-call without the fix will inevitably lead to regressions.

i see 13665 is approved and is rerunning CI now. i will start a revert of this feature enable (9432), and we will have a horse race. 1st one to land , wins the day.

Thanks.