Skip to content

feat(ci): add workflow_call inputs to multi_arch_ci.yml - #8991

Merged
geomin12 merged 2 commits into
mainfrom
users/geomin12/workflow-call-multi-arch-ci
Oct 14, 2026
Merged

feat(ci): add workflow_call inputs to multi_arch_ci.yml#8991
geomin12 merged 2 commits into
mainfrom
users/geomin12/workflow-call-multi-arch-ci

Conversation

@geomin12

@geomin12 geomin12 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

For rocm-libraries, rocm-systems and other external repos, we want to eventually call multi arch CI with one workflow call, rather than having to call setup, linux and windows build+test.

@geomin12 geomin12 added the ci:skip Skip all CI builds/tests for this PR label Oct 13, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Oct 13, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

geomin12
geomin12 commented Oct 13, 2026
View reviewed changes

@geomin12 geomin12 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on #8947 before i land this

@geomin12 geomin12 mentioned this pull request Oct 13, 2026
Merged
geomin12 added a commit that referenced this pull request Oct 13, 2026
@geomin12 @claude
feat(ci): run gfx950 quick tests for compiler bump (#8994)
ef99b92 
as requested, run gfx950 quick tests for compiler bump

after #8991 lands, we will convert
compiler bump to a cleaner format

we'll observe queues. if bad, we'll revert

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Oct 14, 2026
Merged
Merged
@geomin12 geomin12 mentioned this pull request Oct 14, 2026
Merged
geomin12 added a commit that referenced this pull request Oct 14, 2026
@geomin12 @claude
feat(ci): hard-code gfx950 test runner in compiler_bump to fix skippe…
9425860 
…d tests (#9012)

Incredibly temporary solution of adding gfx950 quick tests for
compiler_bump

Will be removed and properly added once
#8991 lands

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ScottTodd
ScottTodd approved these changes Oct 14, 2026
View reviewed changes

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to do the same for https://github.com/ROCm/TheRock/blob/main/.github/workflows/multi_arch_ci_asan.yml ? Or maybe just start with the one for now?

@geomin12

geomin12 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Want to do the same for https://github.com/ROCm/TheRock/blob/main/.github/workflows/multi_arch_ci_asan.yml ? Or maybe just start with the one for now?

good call, let me do that

geomin12 and others added 2 commits October 14, 2026 16:13
@geomin12 @claude
feat(ci): add workflow_call inputs to multi_arch_ci.yml
a686da6 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12 @claude
fix(ci): use pr_labels in workflow_call and add workflow_call to ASAN
e17cad6 
Update multi_arch_ci.yml workflow_call inputs to use pr_labels instead
of the removed linux_test_labels/windows_test_labels. Add workflow_call
trigger to multi_arch_ci_asan.yml so it can be invoked as a reusable
workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 force-pushed the users/geomin12/workflow-call-multi-arch-ci branch from 2350b1b to e17cad6 Compare October 14, 2026 23:15
@geomin12
geomin12 merged commit 98a3c88 into main Oct 14, 2026
21 of 22 checks passed
@geomin12
geomin12 deleted the users/geomin12/workflow-call-multi-arch-ci branch October 14, 2026 23:24
@geomin12 geomin12 mentioned this pull request Oct 16, 2026
Open
@ScottTodd ScottTodd mentioned this pull request Oct 27, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes
@erman-gurses erman-gurses Awaiting requested review from erman-gurses

Assignees

No one assigned

Labels

ci:skip Skip all CI builds/tests for this PR Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geomin12 @ScottTodd