Skip to content

Defer ASan helper imports in component test launchers - #8882

Open
sa-faizal wants to merge 1 commit into
mainfrom
users/safaizal/asan-import-cleanup
Open

sa-faizal wants to merge 1 commit into
mainfrom
users/safaizal/asan-import-cleanup

Conversation

@sa-faizal

@sa-faizal sa-faizal commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Move the ASan helper imports in the HIP and rocprofiler-sdk test launchers into the functions that use them, so release jobs don't load the module unnecessarily. This addresses the review comments on #8721.

Tested: 17 Linux tests passed; 11 Windows tests passed with six POSIX-only tests skipped. Release and ASan launcher smoke checks and pre-commit passed.

Related: #7202

@therock-pr-bot

therock-pr-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@sa-faizal
sa-faizal requested a review from nunnikri October 9, 2026 03:11
@sa-faizal
sa-faizal marked this pull request as ready for review October 9, 2026 03:12

@nunnikri nunnikri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants