Repository navigation
fix(CI): Set ccache as HIP_COMPILER_LAUNCHER - #8824
Conversation
fe582a6 to
a804d4a
Compare
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
a804d4a to
44c0db7
Compare
44c0db7 to
4725ce8
Compare
ScottTodd
left a comment
There was a problem hiding this comment.
Wonderful, thanks!
I found a few other spots we can update too. These can be separate PRs as part of future cleanup though.
- pytorch ccache support (we have code for both ccache and sccache, might prune to just sccache though, cc @subodh-dubey-amd):
TheRock/external-builds/pytorch/build_prod_wheels.py
Lines 853 to 854 in d8b5763
- user docs:
Lines 287 to 345 in d8b5763
- agent docs (which we could trim to point at the user docs):
Lines 84 to 104 in d8b5763
Then a few other scripts too, but some of those are legacy and due to be deleted.
|
@ScottTodd thanks for the review |
I have |
|
PyTorch PR is #9744. Nice speedups there too :) |
Motivation
Currently no workflows use caching for the HIP language compilation. This PR is based on #8783 to use the corresponding parameter in all subprojects
Technical Details
Adds
-DCMAKE_HIP_COMPILER_LAUNCHER=ccacheto both .github/workflows/multi_arch_build_portable_linux_artifacts.yml and .github/workflows/multi_arch_build_windows_artifacts.ymlTest Plan
Test Result
Examples:
Submission Checklist