Skip to content

fix(ci): skip platforms without selected artifacts - #8821

Merged
Groverkss merged 4 commits into
mainfrom
users/Groverkss/skip-empty-platform-ci
Oct 8, 2026
Merged

Groverkss merged 4 commits into
mainfrom
users/Groverkss/skip-empty-platform-ci

Conversation

@Groverkss

@Groverkss Groverkss commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Emulation-only builds produce no Windows artifacts, but Windows CI still runs artifact validation and fails. Related to #6943.

Technical Details

Skip platform configurations when no selected or reused stage produces artifacts for that platform. Omit output links for disabled platforms and write job summaries as UTF-8 for Windows. Linux sanity selection is unchanged.

Test Plan

Regression coverage for partial builds, reused stages, and full builds.

Test Result

Submission Checklist

AI assistance: Codex.

@therock-pr-bot

therock-pr-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@Groverkss
Groverkss marked this pull request as ready for review October 7, 2026 12:29

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. We could also trim the log and artifact links from the summary markdown when a platform is disabled, see https://github.com/ROCm/rocm-systems/actions/runs/37618101072

Image

Code for that is here:

for platform_name in ["linux", "windows"]:
output_root = WorkflowOutputRoot.from_workflow_run(
run_id=ci_inputs.run_id, platform=platform_name
)
if platform_name == "linux":
linux_output_root = output_root
log_url = output_root.log_root_index().https_url
artifact_url = output_root.artifact_index().https_url
manifest_url = output_root.manifests_index().https_url
lines.append(
f"{platform_name.capitalize()} | {log_url} | {artifact_url} | {manifest_url}"
)

@Groverkss

Copy link
Copy Markdown
Contributor Author

Thanks, looks good. We could also trim the log and artifact links from the summary markdown when a platform is disabled, see https://github.com/ROCm/rocm-systems/actions/runs/37618101072

Image Code for that is here:

for platform_name in ["linux", "windows"]:
output_root = WorkflowOutputRoot.from_workflow_run(
run_id=ci_inputs.run_id, platform=platform_name
)
if platform_name == "linux":
linux_output_root = output_root
log_url = output_root.log_root_index().https_url
artifact_url = output_root.artifact_index().https_url
manifest_url = output_root.manifests_index().https_url
lines.append(
f"{platform_name.capitalize()} | {log_url} | {artifact_url} | {manifest_url}"
)

done

@Groverkss
Groverkss merged commit 2fb7b81 into main Oct 8, 2026
167 checks passed
@Groverkss
Groverkss deleted the users/Groverkss/skip-empty-platform-ci branch October 8, 2026 09:17
Groverkss added a commit that referenced this pull request Oct 13, 2026
## Motivation

Emulation-only builds skip `compiler-runtime`, but sanity still runs and
fails on missing compiler/runtime artifacts. Related: #8821 (separate
Windows fix).

## Technical Details

Pass the existing `skip_stages` value into test selection and omit
sanity when `compiler-runtime` is excluded. Built or reused
compiler/runtime stages retain existing sanity coverage.

## Test Plan

Regression tests for excluded and included stages on Linux and Windows;
downstream rocm-systems run with the updated TheRock pin.

## Test Result

- Before: [Linux sanity
fails](https://github.com/ROCm/rocm-systems/actions/runs/37613205332/job/112775002452).
- After: [Linux CI
passes](https://github.com/ROCm/rocm-systems/actions/runs/37622081125),
with sanity correctly skipped.
- Linux/Windows unit tests and pre-commit pass.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

AI assistance: Codex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants