Repository navigation
fix(ci): skip platforms without selected artifacts - #8821
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
ScottTodd
left a comment
There was a problem hiding this comment.
Thanks, looks good. We could also trim the log and artifact links from the summary markdown when a platform is disabled, see https://github.com/ROCm/rocm-systems/actions/runs/37618101072
Code for that is here:
TheRock/build_tools/github_actions/configure_multi_arch_ci_summary.py
Lines 199 to 210 in 4c6a803
done |
## Motivation Emulation-only builds skip `compiler-runtime`, but sanity still runs and fails on missing compiler/runtime artifacts. Related: #8821 (separate Windows fix). ## Technical Details Pass the existing `skip_stages` value into test selection and omit sanity when `compiler-runtime` is excluded. Built or reused compiler/runtime stages retain existing sanity coverage. ## Test Plan Regression tests for excluded and included stages on Linux and Windows; downstream rocm-systems run with the updated TheRock pin. ## Test Result - Before: [Linux sanity fails](https://github.com/ROCm/rocm-systems/actions/runs/37613205332/job/112775002452). - After: [Linux CI passes](https://github.com/ROCm/rocm-systems/actions/runs/37622081125), with sanity correctly skipped. - Linux/Windows unit tests and pre-commit pass. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md. AI assistance: Codex.

Motivation
Emulation-only builds produce no Windows artifacts, but Windows CI still runs artifact validation and fails. Related to #6943.
Technical Details
Skip platform configurations when no selected or reused stage produces artifacts for that platform. Omit output links for disabled platforms and write job summaries as UTF-8 for Windows. Linux sanity selection is unchanged.
Test Plan
Regression coverage for partial builds, reused stages, and full builds.
Test Result
Submission Checklist
AI assistance: Codex.