Repository navigation
test(rocprofiler-compute): check the compute-analyze extra with --verify-deps - #8752
Merged
Merged
Conversation
…ify-deps `rocprof-compute analyze --help` exits in argparse before the dependency check runs, so the step passed even with an empty extra. `--verify-deps` checks every package pinned in rocprofiler-compute's requirements.txt and exits non-zero on any missing or mismatched one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CI change correctly exercises the upstream dependency-verification command.
Review effort: Balanced
Findings: None
What changed in this PR
Updates wheel CI to validate the compute-analyze extra against rocprofiler-compute’s pinned dependencies.
Changes:
- Replaces the ineffective
--helpcheck withanalyze --verify-deps. - Clarifies the dependency-validation comment.
| File | Description |
|---|---|
.github/workflows/test_rocm_wheels.yml |
Verifies installed analyze dependencies and versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jbonnell-amd
approved these changes
Oct 5, 2026
Contributor
Author
|
The relevant test has passed https://github.com/ROCm/TheRock/actions/runs/37328105987/job/111893352526?pr=8752 |
vedithal-amd
deleted the
users/vedithal-amd/compute-analyze-verify-deps
branch
October 5, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The compute-analyze test step runs
rocprof-compute analyze --help. argparse exits on--helpbefore the dependency check runs, and the modules imported up to that point are stdlib-only. So the step passes even if the extra declares no dependencies.Related Issues
ISSUE ID: #7003
JIRA ID: AIPROFCOMP-788
Technical Details
rocprof-compute analyze --verify-deps(added in docs(rocprofiler-compute): install analyze dependencies with the compute-analyze extra rocm-systems#11928, already in the rocm-systems pin) checks every package in rocprofiler-compute'srequirements.txtfor presence and pinned version, then exits non-zero on any mismatch.rocm-profilertemplate'ssetup.pyin TheRock builds the extra from that samerequirements.txt, so the test now checks the extra against its source of truth.Test Plan
Test Result
Submission Checklist
🤖 Generated with Claude Code