Repository navigation
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
dileepr1
left a comment
There was a problem hiding this comment.
The changes look good to avoid startup ASan issues.
@sa-faizal Would you have the link to a test run with this change?
geomin12
left a comment
There was a problem hiding this comment.
going to let Dileep review this one
|
Thanks @geomin12 @dileepr1 here is the run https://github.com/ROCm/TheRock/actions/runs/37393421993 |
|
Pytest started, passed hundreds of tests, and reached 68%. That supports the startup fix working in this run. Full suite failed due to timeout. Increased to an hour and rerun - https://github.com/ROCm/TheRock/actions/runs/37402666539 |
dileepr1
left a comment
There was a problem hiding this comment.
Thanks for the link.
The startup fix holds though the test is red.
Looks good to me.
2e01ffc to
6823d66
Compare
TensileLite pytest jobs can fail during startup when an imported extension loads ASan too late. Preload the discovered runtime when starting the pytest child, preserving existing preloads, sanitizer settings, and the parent environment.
Reuse the existing environment-prepend test to check preload order and parent-environment preservation; no test methods are added. This PR is stacked on #8721 and contains only the pytest follow-up. Retarget to
mainafter that dependency lands.Validation:
ISSUE ID : #8735
AI-assisted change.
Fixes #8735