Repository navigation
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kpack stops at the first compatible archive even when that archive lacks the requested kernel. This causes
hipErrorInvalidImagein gfx942 host-ASan rocSOLVER tests and affects hipSOLVER too.Backport the merged rocm-systems#12518 fix so the loader tries the remaining compatible archives. Remove this temporary patch when the rocm-systems pin includes upstream commit
694068a0c1610c61e22ff33ef574849cd172f13d.Validated on the requested Linux gfx942 host:
daily_lapack/GETRI.__float/0fails with the original loader and passes with the patched loader. XNACK and ASan settings were unchanged; no suppression was added.JIRA ID: ROCM-31644
Closed in favor of the rocm-systems submodule bump containing the upstream fix. Host-ASan CI and automatic follow-up tests were stopped.