Skip to content

fix(kpack): backport compatible archive fallback for pinned runtime - #8722

Closed
sa-faizal wants to merge 1 commit into
mainfrom
users/safaizal/kpack-compatible-archive-backport
Closed

sa-faizal wants to merge 1 commit into
mainfrom
users/safaizal/kpack-compatible-archive-backport

Conversation

@sa-faizal

@sa-faizal sa-faizal commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

kpack stops at the first compatible archive even when that archive lacks the requested kernel. This causes hipErrorInvalidImage in gfx942 host-ASan rocSOLVER tests and affects hipSOLVER too.

Backport the merged rocm-systems#12518 fix so the loader tries the remaining compatible archives. Remove this temporary patch when the rocm-systems pin includes upstream commit 694068a0c1610c61e22ff33ef574849cd172f13d.

Validated on the requested Linux gfx942 host:

  • All 103 kpack runtime tests passed. Both archive-fallback tests fail with the original loader and pass with the fix.
  • Using the original CI artifacts, daily_lapack/GETRI.__float/0 fails with the original loader and passes with the patched loader. XNACK and ASan settings were unchanged; no suppression was added.

JIRA ID: ROCM-31644

Closed in favor of the rocm-systems submodule bump containing the upstream fix. Host-ASan CI and automatic follow-up tests were stopped.

@therock-pr-bot

therock-pr-bot Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@sa-faizal
sa-faizal requested a review from nunnikri October 3, 2026 19:49
@sa-faizal sa-faizal added the ci:host-asan Opt-in to running multi-arch host-asan CI on a pull request label Oct 3, 2026
@sa-faizal sa-faizal closed this Oct 3, 2026
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:host-asan Opt-in to running multi-arch host-asan CI on a pull request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant