Repository navigation
Fix hipFile ASan runtime discovery for per-target layouts - #8719
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
jordan-turbofish
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hipFile host-ASan tests fail before execution because the launcher queries only
libclang_rt.asan-x86_64.so, while per-target toolchains uselibclang_rt.asan.so.Query the existing clang++ location for the current filename, then the legacy filename, and validate the resolved file. The change is limited to the existing launcher; no configuration override or tests are added.
Validation:
ASAN_RUNTIME_PATHwas unset and the ASan runtime directory was absent fromLD_LIBRARY_PATH, directly exercising fallback discovery.Original failure.
ISSUE ID : #6332