Repository navigation
Conversation
- install_rocm_code_coverage_build.py: --code-coverage-run-github-repo and
--code-coverage-release-type, so the instrumented replacement artifacts
can be fetched from a different repository and S3 bucket than the
baseline install. Uses the release_type override added to
create_backend_from_env().
- docs: add code_coverage.md (local builds, local reports, and the coverage
CI flow), document {PROJECT}_ENABLE_COVERAGE in the development guide, and
link both from the docs index and the CI overview.
Split out of #7783.
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Review and merge in order; each PR's diff shows only its own changes.
Based on #8589. Split out of #7783.
Motivation
Part 2 of 4 of the split of #7783 (code coverage): the coverage installer's cross-repo options, and the coverage documentation.
GitHub issue: #6572
Technical Details
build_tools/install_rocm_code_coverage_build.py: adds--code-coverage-run-github-repoand--code-coverage-release-type, so the instrumented replacement artifacts can be fetched from a different repository and S3 bucket than the baseline install. The instrumented build publishes to thecibucket, while a baseline usually comes from a nightly. Uses therelease_typeoverride from part 1.docs/development/code_coverage.md: new. Covers local instrumented builds, producing a report locally, and the coverage CI flow, whose workflows arrive in part 4.docs/development/development_guide.md: documents{PROJECT}_ENABLE_COVERAGE.docs/development/README.mdandci_overview.md: link the new docs.Nothing on main calls
install_rocm_code_coverage_build.pyyet.Test Plan
install_rocm_code_coverage_build_test.py: the instrumented fetch uses the coverage run's repository, not the baseline's, and defaults to$GITHUB_REPOSITORY.artifact_backend_test.py.pre-commit(includingmdformat) on the changed files.Test Result
All of the above pass locally.
Submission Checklist