Repository navigation
fix(ci): respect trigger_test_label_only on postsubmit push events - #8407
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Previously, families with trigger_test_label_only (like gfx125X) would skip tests on PRs without the label but always run tests on postsubmit push events. This was unintended for hardware-constrained families. Now trigger_test_label_only gates tests on both pull_request and push triggers. Only workflow_dispatch bypasses the check (for manual testing). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a7340cc to
312231a
Compare
| if ( | ||
| platform_info.get("trigger_test_label_only", False) | ||
| and ci_inputs.is_pull_request | ||
| and not ci_inputs.is_workflow_dispatch |
There was a problem hiding this comment.
This disables post-submit testing for all gfx, including 90a and 950. Is this intentional? PR description seems to target gfx125x behaviour only.
There was a problem hiding this comment.
ah intended! for gfx950, we lack enough machines, so we only want to run on submodule bumps.
for gfx90a due to outdated driver version, but once that is resolved, we will want to enable for postsubmit. this is a temporary fix, until I get #8322 in which makes all these if and conditionals go away
|
|
||
| def test_trigger_test_label_only_push_always_runs_tests(self): | ||
| """Push (postsubmit) always runs tests regardless of trigger_test_label_only.""" | ||
| def test_trigger_test_label_only_push_without_label_skips_tests(self): |
There was a problem hiding this comment.
Push events wouldn't have PR labels, so this appears to be an invalid test case.
Push events don't have PR labels, so testing that push without labels skips tests is tautological. The behavior is already covered by the push-with-label test which verifies external callers can pass labels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jayhawk-commits
left a comment
jayhawk-commits
left a comment
There was a problem hiding this comment.
nit: Please add note in commit message and PR description that behaviour for gfx950 and gfx90a is changing and intentional.
Summary
trigger_test_label_onlyto gate tests on bothpull_requestandpushtriggersworkflow_dispatchbypasses the check (for manual testing)Test plan
TestFamilyTestFilters)