Skip to content

Introduce more pre-commit hooks.#836

Merged
ScottTodd merged 2 commits into
mainfrom
users/scotttodd/pre-commit-improvements
Jun 17, 2025
Merged

Introduce more pre-commit hooks.#836
ScottTodd merged 2 commits into
mainfrom
users/scotttodd/pre-commit-improvements

Conversation

@ScottTodd
Copy link
Copy Markdown
Member

Progress on #750.

Hook name documentation
check-merge-conflict https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-merge-conflict
mixed-line-ending https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#mixed-line-ending
forbid-tabs https://github.com/Lucas-C/pre-commit-hooks?tab=readme-ov-file#usage

For forbid-tabs, we could also use remove-tabs and automatically replace with 2 or 4 spaces, but I'd rather get the error and fix case by case, since that will ensure we match the local style and indentation.

@benvanik
Copy link
Copy Markdown

This + the cleanup to existing code will be really nice! Projects are very inconsistent even within themselves and it makes editing them require special handling.
image

@ScottTodd
Copy link
Copy Markdown
Member Author

@ScottTodd
Copy link
Copy Markdown
Member Author

Had some file permissions changes sneak in that are tricky to undo... going to force push rebase those away, then merge.

@ScottTodd ScottTodd force-pushed the users/scotttodd/pre-commit-improvements branch from fb38b2b to c7e7c76 Compare June 17, 2025 19:54
@ScottTodd ScottTodd merged commit bd06f33 into main Jun 17, 2025
4 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/pre-commit-improvements branch June 17, 2025 20:13
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants