Repository navigation
Group target tarballs by package owner - #8328
Merged
Merged
Conversation
Individual gfx1250 and gfx1250-strict selections share the gfx1250 archive name while retaining only the requested payloads. Combined selections collect both targets before compression, avoiding separate strict archives or overwritten outputs. Family archive names remain unchanged, and test archives follow the same ownership grouping. The tarball workflow checks out rocm-systems so the ownership adapter can use shared metadata when #8325 lands. Refs #8278 Test plan: - python -m pytest -q -p no:cacheprovider build_tools/packaging/archives/tests build_tools/tests/sdk_targets_test.py Test results: - 15 tests passed, covering individual and combined target selections, both input orders, and test and multiarch archive naming. - Real artifact tarball assembly remains pending CI validation.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
1 task done
ScottTodd
approved these changes
Sep 18, 2026
Comment on lines
+129
to
+130
| - name: Checkout shared package ownership metadata | ||
| run: git submodule update --init --depth 1 rocm-systems |
Member
There was a problem hiding this comment.
Let's add some context in a TODO comment:
- This is just for a specific path (link it)
- Explain that we would like to pip install the bootstrap package instead of needing the source code
Comment on lines
+129
to
+130
| - name: Checkout shared package ownership metadata | ||
| run: git submodule update --init --depth 1 rocm-systems |
Member
Author
There was a problem hiding this comment.
The ownership is still defined in rocm-system's bootstrap, thus it will still be needed.
marbre
added a commit
that referenced
this pull request
Oct 30, 2026
## Motivation Family selection must include both gfx1250 targets for builds, distributions, and artifact fetching. Default test compilation includes strict along with the other registered targets. Explicit individual target selections retain their own payload identity. Closes #8278 ## Technical Details Prerequisites before landing: - ~~#8325: shared SDK ownership.~~ (superseded) - #8377: centralized target ownership. - #8327: native package ownership. - #8328: tarball ownership. - ~~A rocm-systems submodule bump containing ROCm/rocm-systems#11801.~~ **(landed)** - Established broader component readiness for family enablement. ## Test Plan Fresh compiler/HIP/RAND builds and SDK, DEB/RPM, and tarball validation passed on the integration branch with temporary family membership. The exact family enablement was then integrated for a combined build with RAND tests and target-neutral hipthreads. Test target overrides were left empty to exercise the default registered-target list. These checks do not establish full component or GPU execution support. - python -m pytest -q -p no:cacheprovider build_tools/tests/cmake_amdgpu_targets_test.py build_tools/tests/artifact_manager_tool_test.py build_tools/github_actions/tests/configure_multi_arch_ci_test.py - cmake --build ../therock-build-rand-tests-gfx125X-dcgpu --target artifact-rand artifact-hipthreads - ../therock-build-rand-tests-gfx125X-dcgpu/compiler/amd-llvm/dist/lib/llvm/bin/llvm-objdump --offloading ../therock-build-rand-tests-gfx125X-dcgpu/math-libs/hipthreads/stage/lib/hipthreads/libhipthreads.a - python -m rocm_kpack.tools.verify_artifacts --artifacts-dir ../therock-build-rand-tests-gfx125X-dcgpu/artifacts --verbose --clang-offload-bundler ../therock-build-rand-tests-gfx125X-dcgpu/compiler/amd-llvm/dist/lib/llvm/bin/clang-offload-bundler ## Test Result - 171 passed and 1 existing test skipped with umask 022. - rocRAND and hipRAND tests compiled for both gfx1250 targets. Each target's test kpack contains 34 entries with only its target identity. - Target-neutral hipthreads compiled with the default test target list. Its library contains exactly 29 distinct device images, including separate gfx1250 and gfx1250-strict images. - All four artifact verifier checks passed. - No GPU tests were executed. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md. Generated with Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Individual gfx1250 and gfx1250-strict selections share the gfx1250 archive name while retaining only the requested payloads. Combined selections collect both targets before compression, avoiding separate strict archives or overwritten outputs.
Progress on #8278.
Technical Details
Family archive names remain unchanged, and test archives follow the same ownership grouping.
The tarball workflow checks out rocm-systems so the ownership adapter can use shared metadata when #8325 lands.
Test Plan
Test Result
Submission Checklist
Generated with Codex