Repository navigation
fix(ci): skip gfx90a tests on PRs unless explicitly labeled - #8319
Merged
Merged
Conversation
gfx90a is a postsubmit-only architecture that was being tested on PRs when ci:run-all-archs label was present (e.g., submodule bumps). This adds trigger_test_label_only to gfx90a so tests only run when the gfx90a label is explicitly added. Also fixes the trigger_test_label_only check to only apply to PRs - push (postsubmit) and workflow_dispatch should always run tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
geomin12
requested review from
ScottTodd and
jayhawk-commits
as code owners
September 17, 2026 20:50
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
ScottTodd
approved these changes
Sep 17, 2026
Comment on lines
+1981
to
+1982
| def test_gfx90a_always_runs_tests(self): | ||
| """gfx90a (no trigger_test_label_only) runs tests on push and workflow_dispatch.""" | ||
| def test_gfx90a_runs_tests_on_push_and_workflow_dispatch(self): | ||
| """gfx90a (trigger_test_label_only) runs tests on push and workflow_dispatch.""" |
Member
There was a problem hiding this comment.
This file is growing quite a lot of test code for single targets that appear to be change detector tests that will fail as soon as the code changes too. The expectation (whether in policies, our heads, or in agent default behavior) that "all code changes have associated test changes" is hurting us here.
How about writing some tests with a test version of amdgpu_family_info_matrix_postsubmit that show how trigger_test_label_only and other fields should work and then letting the CI configuration change without always needing updates to unit tests?
Replace tests that depend on real production family names (gfx90a, gfx125x, gfx950) with tests using synthetic mock families. This decouples tests from CI configuration changes and avoids "change detector" tests that break whenever the family matrix is modified. The mock families (mock-presubmit, mock-postsubmit-labeled, mock-quick-only) demonstrate how trigger_test_label_only and test_type_for_family should behave without depending on actual production configurations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ScottTodd
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gfx90a is a postsubmit-only architecture that was being tested on PRs when ci:run-all-archs label was present (e.g., submodule bumps). This adds trigger_test_label_only to gfx90a so tests only run when the gfx90a label is explicitly added.
Also fixes the trigger_test_label_only check to only apply to PRs - push (postsubmit) and workflow_dispatch should always run tests.
After this PR, I will work on #8222 to make this clearer