Repository navigation
TheRock : Code Coverage #7783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TheRock : Code Coverage #7783
Changes from 1 commit
0214f28
0782640
80dd996
2a61a87
45d0240
68e02ba
607eadc
fea36e0
7c1920f
e805f9d
8a0b2df
8e47979
4b44848
0585dc3
1fa0945
fbadbae
387ac8a
a049768
1e6f606
515f8d6
4d4f8f7
2ece46a
b695ade
f1cd929
eec2a1a
255d8a1
ba01c07
3f2e7b2
cb09128
476a378
5d0b916
5767295
00edba1
2e0087a
47d647b
11b1273
ef3dc04
4f177cd
acefa49
cba8728
7e333da
c0c48d2
9e4f0c6
af064e4
96766ae
81154af
08f3f91
ba77777
82a0f5b
0692f1a
3f6170f
9a3f764
cdc1f15
864a16e
5085c48
7be1cf8
df04afe
30d41ca
713e830
e110010
a50d107
5649642
2c0c640
8f1bbb0
8523c5a
21ddceb
aaec681
76a5025
f1aab3c
f642523
80e80ed
05660fc
8ad0f69
88f0ddf
25a70b6
d9d3fef
879322a
c3127af
9e97c65
538701c
97e9708
a556b47
ac9d49a
c9a42ba
78424fc
aae21c8
161ef7a
111ce86
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,24 @@ on: | |
| type: string | ||
| default: "" | ||
| description: "Comma-separated build stages to skip (artifacts already copied by the orchestrator)" | ||
| build_stages: | ||
| type: string | ||
| default: "" | ||
| description: >- | ||
| Comma-separated allowlist of build stages to run. Empty runs every | ||
| stage. Variant pipelines such as coverage use this to build only the | ||
| stages they need. | ||
| stage_projects: | ||
| type: string | ||
| default: "" | ||
| description: >- | ||
| Space-separated project names to narrow per-arch stages down to | ||
| (e.g. "hiprand"). Empty builds every project in the stage. | ||
| extra_cmake_options: | ||
| type: string | ||
| default: "" | ||
| description: >- | ||
| Extra -D options appended to each stage's configure command. | ||
| skip_stages: | ||
| type: string | ||
| default: "" | ||
|
|
@@ -96,6 +114,13 @@ jobs: | |
| # STAGE: compiler-runtime (generic) | ||
| # ========================================================================== | ||
| compiler-runtime: | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'compiler-runtime') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',compiler-runtime,')) | ||
| }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we have only one
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is invalid yaml and the workflow does not run: https://github.com/ROCm/TheRock/actions/runs/33431950362
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can probably undo the changes in this file, and then call multi_arch_build_portable_linux_artifacts.yml in your workflows as follows: jobs:
build_instrumented_compiler_runtime:
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
with:
stage_name: compiler-runtime
extra_cmake_options: -DCOMPILER_RT_BUILD_PROFILE_ROCM=ON
build_instrumented_math_libs:
needs: build_instrumented_compiler_runtime
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
with:
stage_name: math-libs
stage_projects: "hiprand;rocrand;hipfft;rocfft" # All projects to instrument
extra_cmake_options: -DTHEROCK_COVERAGE_ROCM_LIBRARIES_ALL=ON
test_coverage:
needs: build_instrumented_math_libs
strategy:
matrix:
project: [hiprand, rocrand, hipfft, rocfft]
uses: ./.github/workflows/test_component.yml
with:
component: ${{ matrix.project }}
coverage_enabled: trueReally all you seem to be doing with these changes is adding a bunch of conditionals so that we can filter everything except for compiler-runtime and math-libs, and eventually rocm-systems, so this might be a more ideal approach.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. Removed all changes from this file. Please review |
||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'compiler-runtime') && !contains(inputs.skip_stages, 'compiler-runtime') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -106,6 +131,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -121,6 +148,13 @@ jobs: | |
| # ========================================================================== | ||
| runtime-tests: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'runtime-tests') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',runtime-tests,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'runtime-tests') && !contains(inputs.skip_stages, 'runtime-tests') }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above - Shouldn't we have only one
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -131,6 +165,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -146,6 +182,13 @@ jobs: | |
| # ========================================================================== | ||
| wsl-rocdxg: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'wsl-rocdxg') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',wsl-rocdxg,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'wsl-rocdxg') && !contains(inputs.skip_stages, 'wsl-rocdxg') }} | ||
| uses: ./.github/workflows/multi_arch_build_wsl_rocdxg_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -170,6 +213,13 @@ jobs: | |
| # ========================================================================== | ||
| math-libs: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'math-libs') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',math-libs,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'math-libs') && !contains(inputs.skip_stages, 'math-libs') }} | ||
| strategy: | ||
| # `fail-fast: false` lets all families complete even if one fails. | ||
|
|
@@ -190,6 +240,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -208,6 +260,13 @@ jobs: | |
| # ========================================================================== | ||
| comm-libs: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'comm-libs') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',comm-libs,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'comm-libs') && !contains(inputs.skip_stages, 'comm-libs') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -219,6 +278,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -235,6 +296,13 @@ jobs: | |
| # ========================================================================== | ||
| storage-libs: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'storage-libs') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',storage-libs,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'storage-libs') && !contains(inputs.skip_stages, 'storage-libs') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -246,6 +314,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -261,6 +331,13 @@ jobs: | |
| # ========================================================================== | ||
| debug-tools: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'debug-tools') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',debug-tools,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'debug-tools') && !contains(inputs.skip_stages, 'debug-tools') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -271,6 +348,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -286,6 +365,13 @@ jobs: | |
| # ========================================================================== | ||
| dctools-core: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'dctools-core') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',dctools-core,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'dctools-core') && !contains(inputs.skip_stages, 'dctools-core') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -296,6 +382,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -311,6 +399,13 @@ jobs: | |
| # ========================================================================== | ||
| profiler-apps: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'profiler-apps') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',profiler-apps,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'profiler-apps') && !contains(inputs.skip_stages, 'profiler-apps') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -321,6 +416,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -336,6 +433,13 @@ jobs: | |
| # ========================================================================== | ||
| cv-libs: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'cv-libs') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',cv-libs,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'cv-libs') && !contains(inputs.skip_stages, 'cv-libs') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -346,6 +450,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
@@ -361,6 +467,13 @@ jobs: | |
| # ========================================================================== | ||
| media-libs: | ||
| needs: compiler-runtime | ||
| if: >- | ||
| ${{ | ||
| !cancelled() && !failure() && | ||
| !contains(inputs.prebuilt_stages, 'media-libs') && | ||
| (inputs.build_stages == '' || | ||
| contains(format(',{0},', inputs.build_stages), ',media-libs,')) | ||
| }} | ||
| if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'media-libs') && !contains(inputs.skip_stages, 'media-libs') }} | ||
| uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml | ||
| secrets: inherit | ||
|
|
@@ -371,6 +484,8 @@ jobs: | |
| dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }} | ||
| rocm_package_version: ${{ inputs.rocm_package_version }} | ||
| build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }} | ||
| stage_projects: ${{ inputs.stage_projects }} | ||
| extra_cmake_options: ${{ inputs.extra_cmake_options }} | ||
| build_runs_on: ${{ inputs.build_runs_on }} | ||
| release_type: ${{ inputs.release_type }} | ||
| repository: ${{ inputs.repository }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need both of these variables for a nightly code coverage run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do. Please revert the changes in this file, since they are not needed. You can localize your changes to .github/workflows/multi_arch_build_portable_linux_artifacts.yml.
Also, please make sure you are fetching the most recent changes to the RFC and confirming that your branch remains in alignment with what is documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted.