Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
0214f28
code coverage migration in TheRock
jainprad Aug 31, 2026
0782640
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 1, 2026
80dd996
fix(ci): merge duplicate `if` keys in portable linux build stages
endurthiabhilash Sep 1, 2026
2a61a87
Merge remote-tracking branch 'origin/main' into users/jainprad/codeco…
endurthiabhilash Sep 1, 2026
45d0240
fix(test): make merge_coverage_report command assertions path-separat…
endurthiabhilash Sep 1, 2026
68e02ba
Merge remote-tracking branch 'origin/main' into users/jainprad/codeco…
endurthiabhilash Sep 2, 2026
607eadc
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 2, 2026
fea36e0
refactor(ci): keep code coverage out of the shared build pipeline
jainprad Sep 2, 2026
7c1920f
feat(ci): nightly code coverage via downstream trigger from the nightly
jainprad Sep 3, 2026
e805f9d
refactor(ci): drop PR coverage entry point, keep nightly only
jainprad Sep 3, 2026
8a0b2df
docs: add end-to-end nightly code coverage flow
jainprad Sep 3, 2026
8e47979
refactor(ci): defer the nightly downstream coverage trigger
jainprad Sep 7, 2026
4b44848
DO NOT MERGE: run the coverage workflow from this branch
jainprad Sep 7, 2026
0585dc3
refactor(ci): make the coverage run self-contained
jainprad Sep 7, 2026
1fa0945
fix(ci): forward each project's own coverage option
jainprad Sep 7, 2026
fbadbae
feat(ci): run nightly coverage against a real nightly baseline
jainprad Sep 7, 2026
387ac8a
ci: narrow the coverage PR check to hipRAND
jainprad Sep 7, 2026
a049768
fix(cmake): link the profile runtime's dependencies for coverage builds
jainprad Sep 7, 2026
1e6f606
ci(coverage): build only the stages phase 1 can use
jainprad Sep 7, 2026
515f8d6
ci(coverage): widen the PR check to the compiled rocm-libraries
jainprad Sep 7, 2026
4d4f8f7
coverage: take hipBLASLt out of the automatic selections
jainprad Sep 7, 2026
2ece46a
coverage: measure host code only, and fix two wrong registry entries
jainprad Sep 8, 2026
b695ade
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 8, 2026
f1cd929
coverage: fix the lint failures on the host-only change
jainprad Sep 8, 2026
eec2a1a
coverage: block hipTensor, whose instrumented build exceeds the code …
jainprad Sep 8, 2026
255d8a1
docs: merge the coverage flow walkthrough into code_coverage.md
jainprad Sep 8, 2026
ba01c07
docs: add the plain-language coverage walkthrough
jainprad Sep 8, 2026
3f2e7b2
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 9, 2026
cb09128
coverage: publish an HTML report and a text summary beside the lcov
jainprad Sep 9, 2026
476a378
docs: correct the coverage entry point description in the CI overview
jainprad Sep 10, 2026
5d0b916
ci(coverage): stop passing the deprecated KPACK_SPLIT_ARTIFACTS flag
jainprad Sep 15, 2026
5767295
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 15, 2026
00edba1
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 16, 2026
2e0087a
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
endurthiabhilash Sep 18, 2026
47d647b
refactor(ci): drive code coverage via test_code_coverage_component an…
endurthiabhilash Sep 21, 2026
11b1273
style(ci): apply black to code coverage installer test
endurthiabhilash Sep 21, 2026
ef3dc04
docs(ci): tighten verbose coverage comments to plain style
endurthiabhilash Sep 21, 2026
4f177cd
refactor(ci): remove L1 thin parent; make _linux.yml the direct dispa…
endurthiabhilash Sep 21, 2026
acefa49
docs(coverage): trim docs and drop nightly walkthrough
endurthiabhilash Sep 21, 2026
cba8728
style(ci): simplify comments in coverage workflows and scripts
endurthiabhilash Sep 21, 2026
7e333da
fix(test): use Path for demangler assertion; apply mdformat to code_c…
endurthiabhilash Sep 21, 2026
c0c48d2
fix(ci): add setup-python before coverage install step
endurthiabhilash Sep 22, 2026
9e4f0c6
feat(ci): add baseline_release_type input for coverage baseline
madkasul Sep 22, 2026
af064e4
Dropping baseline_repository parameter
madkasul Sep 22, 2026
96766ae
Dropping baseline_repository parameter
madkasul Sep 22, 2026
81154af
Dropping baseline_repository parameter
madkasul Sep 22, 2026
08f3f91
fix(ci): use ci release type for instrumented artifact lookup
endurthiabhilash Sep 22, 2026
ba77777
fix(ci): restore cross-repo baseline plumbing for coverage install
endurthiabhilash Sep 22, 2026
82a0f5b
test(ci): trim PR-check coverage to hipblas,hipdnn
endurthiabhilash Sep 22, 2026
0692f1a
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
endurthiabhilash Sep 23, 2026
3f6170f
fix(ci): drop empty additional_requirements_files default
endurthiabhilash Sep 23, 2026
9a3f764
fix(ci): pin TheRock repo/ref for coverage checkouts on cross-repo ca…
endurthiabhilash Sep 23, 2026
cdc1f15
fix(ci): take repository/ref as inputs for coverage checkouts
endurthiabhilash Sep 23, 2026
864a16e
fix(ci): pass repository/ref to instrumented build calls
endurthiabhilash Sep 23, 2026
5085c48
refactor(ci): drop unreachable coverage overlay path
endurthiabhilash Sep 25, 2026
7be1cf8
fix(ci): restore additional_requirements_files default, harden covera…
endurthiabhilash Sep 25, 2026
df04afe
chore(ci): remove temporary coverage PR-check scaffolding
endurthiabhilash Sep 25, 2026
30d41ca
fix(ci): restore workflow_call trigger needed by cross-repo caller
endurthiabhilash Sep 25, 2026
713e830
Merge remote-tracking branch 'origin/main' into users/jainprad/codeco…
endurthiabhilash Sep 25, 2026
e110010
docs(ci): drop hand-copied coverage trigger snippet; fix stale dispat…
endurthiabhilash Sep 25, 2026
a50d107
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 28, 2026
5649642
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
jainprad Sep 29, 2026
2c0c640
docs(coverage): correct stale coverage CI descriptions
jainprad Sep 29, 2026
8f1bbb0
ci(coverage): rename build_instrumented_compiler_runtime to build_com…
jainprad Sep 29, 2026
8523c5a
fix(coverage): keep coverage builds off ccache and in their own S3 na…
jainprad Oct 5, 2026
21ddceb
ci(coverage): let a same-run baseline build in parallel with coverage
jainprad Oct 5, 2026
aaec681
fix(coverage): keep the profile runtime's GPU half out of instrumente…
jainprad Oct 5, 2026
76a5025
fix(coverage): pin the program header table kpack moves in instrument…
jainprad Oct 5, 2026
f1aab3c
ci(coverage): pushing coverage results to codecov.io
madkasul Oct 6, 2026
f642523
fix(coverage): resolve HIP calls before rocSPARSE's profile runtime a…
jainprad Oct 8, 2026
80e80ed
fix(coverage): swap in every file of the project's stage directories
jainprad Oct 9, 2026
05660fc
fix(coverage): render each file once in the HTML report
jainprad Oct 9, 2026
8ad0f69
ci(coverage): added token to push coverage results to codecov.io
madkasul Oct 12, 2026
88f0ddf
Fixing - codecov fileNotFound issue
madkasul Oct 19, 2026
25a70b6
Fixing - codecov fileNotFound issue
madkasul Oct 20, 2026
d9d3fef
correction to the cwd of codecov upload
madkasul Oct 21, 2026
879322a
Options corrections to Codecov
madkasul Oct 21, 2026
c3127af
codecov submodule fix
madkasul Oct 21, 2026
9e97c65
Fix coverage lcov paths and Codecov working-directory for rocm-librar…
endurthiabhilash Oct 22, 2026
538701c
fix(coverage): replace shared kpack with the instrumented host binaries
madkasul Nov 5, 2026
97e9708
Merge remote-tracking branch 'origin/main' into users/jainprad/codeco…
madkasul Nov 6, 2026
a556b47
fix(coverage): swap a wrapper's same-artifact backend too
madkasul Nov 6, 2026
ac9d49a
fix(coverage): build prim projects without hipCCL in coverage runs
madkasul Nov 9, 2026
c9a42ba
fix(coverage): swap hipSPARSELt's host libs from the blas artifact
madkasul Nov 11, 2026
78424fc
Remove wait_for_baseline job and script from coverage workflow
endurthiabhilash Nov 11, 2026
aae21c8
Re-enable hipBLASLt in code coverage registry
endurthiabhilash Nov 11, 2026
161ef7a
Guard coverage_report matrix against empty setup output
endurthiabhilash Nov 11, 2026
111ce86
Merge branch 'main' into users/jainprad/codecoverage-workflows-therock
endurthiabhilash Nov 13, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 115 additions & 0 deletions .github/workflows/multi_arch_build_portable_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,24 @@ on:
type: string
default: ""
description: "Comma-separated build stages to skip (artifacts already copied by the orchestrator)"
build_stages:
type: string
default: ""
description: >-
Comma-separated allowlist of build stages to run. Empty runs every
stage. Variant pipelines such as coverage use this to build only the
stages they need.
stage_projects:
type: string
default: ""
description: >-
Space-separated project names to narrow per-arch stages down to
(e.g. "hiprand"). Empty builds every project in the stage.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need both of these variables for a nightly code coverage run?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do. Please revert the changes in this file, since they are not needed. You can localize your changes to .github/workflows/multi_arch_build_portable_linux_artifacts.yml.

Also, please make sure you are fetching the most recent changes to the RFC and confirming that your branch remains in alignment with what is documented.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted.

extra_cmake_options:
type: string
default: ""
description: >-
Extra -D options appended to each stage's configure command.
skip_stages:
type: string
default: ""
Expand Down Expand Up @@ -96,6 +114,13 @@ jobs:
# STAGE: compiler-runtime (generic)
# ==========================================================================
compiler-runtime:
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'compiler-runtime') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',compiler-runtime,'))
}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have only one if block? AFAIK, GitHub Actions rejects duplicate keys in a mapping. Please check and merge the if block conditions into one block, delete the duplicate.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is invalid yaml and the workflow does not run: https://github.com/ROCm/TheRock/actions/runs/33431950362

Invalid workflow file: .github/workflows/multi_arch_ci.yml#L139
error parsing called workflow
".github/workflows/multi_arch_ci.yml"
-> "./.github/workflows/multi_arch_ci_linux.yml"
--> "./.github/workflows/multi_arch_build_portable_linux.yml"
: (Line: 124, Col: 5): 'if' is already defined, (Line: 158, Col: 5): 'if' is already defined, (Line: 192, Col: 5): 'if' is already defined, (Line: 223, Col: 5): 'if' is already defined, (Line: 270, Col: 5): 'if' is already defined, (Line: 306, Col: 5): 'if' is already defined, (Line: 341, Col: 5): 'if' is already defined, (Line: 375, Col: 5): 'if' is already defined, (Line: 409, Col: 5): 'if' is already defined, (Line: 443, Col: 5): 'if' is already defined

@reboss reboss Sep 2, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can probably undo the changes in this file, and then call multi_arch_build_portable_linux_artifacts.yml in your workflows as follows:

  jobs:
    build_instrumented_compiler_runtime:
      uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
      with:
        stage_name: compiler-runtime
        extra_cmake_options: -DCOMPILER_RT_BUILD_PROFILE_ROCM=ON

    build_instrumented_math_libs:
      needs: build_instrumented_compiler_runtime
      uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
      with:
        stage_name: math-libs
        stage_projects: "hiprand;rocrand;hipfft;rocfft"  # All projects to instrument
        extra_cmake_options: -DTHEROCK_COVERAGE_ROCM_LIBRARIES_ALL=ON

    test_coverage:
      needs: build_instrumented_math_libs
      strategy:
        matrix:
          project: [hiprand, rocrand, hipfft, rocfft]
      uses: ./.github/workflows/test_component.yml
      with:
        component: ${{ matrix.project }}
        coverage_enabled: true

Really all you seem to be doing with these changes is adding a bunch of conditionals so that we can filter everything except for compiler-runtime and math-libs, and eventually rocm-systems, so this might be a more ideal approach.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed all changes from this file. Please review

if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'compiler-runtime') && !contains(inputs.skip_stages, 'compiler-runtime') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -106,6 +131,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -121,6 +148,13 @@ jobs:
# ==========================================================================
runtime-tests:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'runtime-tests') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',runtime-tests,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'runtime-tests') && !contains(inputs.skip_stages, 'runtime-tests') }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above - Shouldn't we have only one if block? AFAIK, GitHub Actions rejects duplicate keys in a mapping. Please check and merge the if block conditions into one block, delete the duplicate. This is also applicable to multiple other instances in this yml.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -131,6 +165,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -146,6 +182,13 @@ jobs:
# ==========================================================================
wsl-rocdxg:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'wsl-rocdxg') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',wsl-rocdxg,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'wsl-rocdxg') && !contains(inputs.skip_stages, 'wsl-rocdxg') }}
uses: ./.github/workflows/multi_arch_build_wsl_rocdxg_artifacts.yml
secrets: inherit
Expand All @@ -170,6 +213,13 @@ jobs:
# ==========================================================================
math-libs:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'math-libs') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',math-libs,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'math-libs') && !contains(inputs.skip_stages, 'math-libs') }}
strategy:
# `fail-fast: false` lets all families complete even if one fails.
Expand All @@ -190,6 +240,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -208,6 +260,13 @@ jobs:
# ==========================================================================
comm-libs:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'comm-libs') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',comm-libs,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'comm-libs') && !contains(inputs.skip_stages, 'comm-libs') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -219,6 +278,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -235,6 +296,13 @@ jobs:
# ==========================================================================
storage-libs:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'storage-libs') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',storage-libs,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'storage-libs') && !contains(inputs.skip_stages, 'storage-libs') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -246,6 +314,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -261,6 +331,13 @@ jobs:
# ==========================================================================
debug-tools:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'debug-tools') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',debug-tools,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'debug-tools') && !contains(inputs.skip_stages, 'debug-tools') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -271,6 +348,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -286,6 +365,13 @@ jobs:
# ==========================================================================
dctools-core:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'dctools-core') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',dctools-core,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'dctools-core') && !contains(inputs.skip_stages, 'dctools-core') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -296,6 +382,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -311,6 +399,13 @@ jobs:
# ==========================================================================
profiler-apps:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'profiler-apps') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',profiler-apps,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'profiler-apps') && !contains(inputs.skip_stages, 'profiler-apps') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -321,6 +416,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -336,6 +433,13 @@ jobs:
# ==========================================================================
cv-libs:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'cv-libs') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',cv-libs,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'cv-libs') && !contains(inputs.skip_stages, 'cv-libs') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -346,6 +450,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand All @@ -361,6 +467,13 @@ jobs:
# ==========================================================================
media-libs:
needs: compiler-runtime
if: >-
${{
!cancelled() && !failure() &&
!contains(inputs.prebuilt_stages, 'media-libs') &&
(inputs.build_stages == '' ||
contains(format(',{0},', inputs.build_stages), ',media-libs,'))
}}
if: ${{ !cancelled() && !failure() && !contains(inputs.prebuilt_stages, 'media-libs') && !contains(inputs.skip_stages, 'media-libs') }}
uses: ./.github/workflows/multi_arch_build_portable_linux_artifacts.yml
secrets: inherit
Expand All @@ -371,6 +484,8 @@ jobs:
dist_amdgpu_families: ${{ inputs.dist_amdgpu_families }}
rocm_package_version: ${{ inputs.rocm_package_version }}
build_variant_cmake_preset: ${{ inputs.build_variant_cmake_preset }}
stage_projects: ${{ inputs.stage_projects }}
extra_cmake_options: ${{ inputs.extra_cmake_options }}
build_runs_on: ${{ inputs.build_runs_on }}
release_type: ${{ inputs.release_type }}
repository: ${{ inputs.repository }}
Expand Down
18 changes: 17 additions & 1 deletion .github/workflows/multi_arch_build_portable_linux_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,20 @@ on:
required: false
default: ""
description: "CMake preset name for this build variant (optional)"
stage_projects:
type: string
required: false
default: ""
description: >-
Space-separated project names to narrow the stage down to (e.g.
"hiprand"). Empty builds every project in the stage.
extra_cmake_options:
type: string
required: false
default: ""
description: >-
Extra -D options appended to the configure command, after the
stage-derived arguments. Used by variant builds such as coverage.
release_type:
description: 'Release type; controls artifact bucket and IAM role'
type: string
Expand Down Expand Up @@ -173,6 +187,7 @@ jobs:
--stage="${STAGE_NAME}" \
--amdgpu-families="${{ inputs.amdgpu_family }}" \
--dist-amdgpu-families="${{ inputs.dist_amdgpu_families }}" \
${{ inputs.stage_projects && format('--projects {0}', inputs.stage_projects) || '' }} \
--manylinux \
--gha-output

Expand All @@ -189,7 +204,8 @@ jobs:
${{ inputs.build_variant_cmake_preset && format('--preset={0}', inputs.build_variant_cmake_preset) }} \
${{ inputs.external_repo_config != '' && format('-DTHEROCK_{0}_SOURCE_DIR={1}', fromJSON(inputs.external_repo_config).source_package, fromJSON(inputs.external_repo_config).checkout_path) || '' }} \
${{ inputs.external_repo_config != '' && fromJSON(inputs.external_repo_config).extra_cmake_options || '' }} \
${{ steps.stage_config.outputs.cmake_args }}
${{ steps.stage_config.outputs.cmake_args }} \
${{ inputs.extra_cmake_options }}

- name: Build stage
run: |
Expand Down
Loading
Loading