Repository navigation
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
|
Need to add "core-hrr" entry to build_tools/packaging/linux/package.json to include hrr-playback in linux packaging. |
Contributor
Author
|
Addressed the review comment in commit Added
Validation:
|
mangupta
force-pushed
the
hrr-orchestration
branch
from
September 3, 2026 02:32
4147d8e to
4111261
Compare
Contributor
Author
|
Addressed the latest review feedback:
Validation: TheRock JSON/TOML validation, rocm-systems CI matrix tests (32), HRR script tests (24), and HRR unit CTest pass. |
Contributor
Author
|
Updated the related rocm-systems PR reference from the closed #10761 to the replacement draft PR #11157. The TheRock gitlink is already pinned to rocm-systems commit |
mangupta
force-pushed
the
hrr-orchestration
branch
from
September 3, 2026 12:07
4111261 to
6a99968
Compare
mangupta
marked this pull request as ready for review
September 3, 2026 12:08
mangupta
requested review from
a team,
arvindcheru,
nunnikri and
raramakr
as code owners
September 3, 2026 12:08
mangupta
force-pushed
the
hrr-orchestration
branch
from
September 3, 2026 16:17
6a99968 to
cdb46c5
Compare
Contributor
Author
|
Updated the paired TheRock PR to follow the rocm-systems review fixes:
The runtime-capture relocation proposal remains deferred. |
lamikr
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Sep 9, 2026
## Summary - Move HRR portable layer (wire format, playback, generator, docs, skills, tests) to `projects/hrr`. - Keep runtime capture in CLR and add a hip-tests capture smoke sentinel. - Add HRR label/CODEOWNERS metadata and update docs/skills for standalone playback builds. - Add build-only TheRock CI matrix coverage for `projects/hrr` changes and make GPU integration tests explicit opt-in. ## Validation - Static checks: no flat `hrr_api_args.h` includes; no stale old playback paths; no conflict markers or pycache artifacts. - TheRock CI matrix tests: 32 passed. - HRR script tests: 24 passed. - Generator idempotency: checksum-stable. - HRR unit CTest passed. - HRR integration and `hrr-playback` build passed locally with HIP compiler setup. - hip-tests `Unit_HRR_CaptureSmoke` passed locally. ## Pending / follow-up - Full CLR `amdhip64` build needs a matching ROCm/HSA toolchain; the local attempt hit an unrelated HSA header mismatch. - HRR integration runtime parity/datacenter validation remains environment-dependent. - TheRock orchestration/packaging is paired in ROCm/TheRock#7669. - Runtime capture relocation remains intentionally out of scope for this PR. ## Related - ROCm/TheRock#7669 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Daniel Olsson <Daniel.Olsson@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
mangupta
force-pushed
the
hrr-orchestration
branch
from
September 15, 2026 09:49
cdb46c5 to
4d353b5
Compare
Contributor
Author
|
Rebased PR #7669 onto the latest TheRock main and resolved the rocm-systems submodule conflict. The temporary forced HRR pin has been removed: the branch now uses the current mainline rocm-systems gitlink The HRR orchestration, packaging, and explicit integration-test build settings remain intact. JSON/TOML validation passes. |
Contributor
|
The ci is failing in runtime step. Please fix it before getting it for review. |
danielbolsson
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Sep 16, 2026
…#11686) ## Summary `projects/hrr/tests/integration/hrr_repro_workload_test.cc` calls `hsa_amd_memory_fill` directly, but the `hrr-integration-tests` target links no ROCr. `hip::host` resolves ROCr for its own needs and does not carry it in its link interface, so the call has no definition at link time. Name the runtime on the target, guarded by `NOT WIN32` because Windows has no ROCr and the call site compiles out there. ## Why this was not caught `HRR_BUILD_INTEGRATION_TESTS` defaults to `OFF`, so nothing in CI had ever compiled the target. The migration in #11157 landed the `hsa_amd_memory_fill` call on develop on 2026-09-09; this link fix was written on 2026-09-10 and stayed on a topic branch. ## How it surfaced ROCm/TheRock#7669 turns `HRR_BUILD_INTEGRATION_TESTS` on, making it the first build anywhere to compile the target. It fails against the current develop gitlink: ``` ld.lld: error: undefined symbol: hsa_amd_memory_fill >>> referenced by hrr_repro_workload_test.cc >>> tests/integration/CMakeFiles/hrr-integration-tests.dir/hrr_repro_workload_test.cc.o ``` That CI failure cannot be fixed inside TheRock: it builds rocm-systems at a pinned gitlink, so this has to land here first and the pin move past it. ## Validation - The integration target links and the full suite passes with this change on `users/danielbolsson/hrr-development`: 23 unit and 70 integration tests green locally on gfx950, and green across gfx94x, gfx950, gfx103x, gfx110x, gfx1150, gfx1151 and gfx120x in CI. - No functional change. One CMake block, build configuration only. Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
dlamd1dai
pushed a commit
to dlamd1dai/rocm-systems
that referenced
this pull request
Sep 16, 2026
## Summary - Move HRR portable layer (wire format, playback, generator, docs, skills, tests) to `projects/hrr`. - Keep runtime capture in CLR and add a hip-tests capture smoke sentinel. - Add HRR label/CODEOWNERS metadata and update docs/skills for standalone playback builds. - Add build-only TheRock CI matrix coverage for `projects/hrr` changes and make GPU integration tests explicit opt-in. ## Validation - Static checks: no flat `hrr_api_args.h` includes; no stale old playback paths; no conflict markers or pycache artifacts. - TheRock CI matrix tests: 32 passed. - HRR script tests: 24 passed. - Generator idempotency: checksum-stable. - HRR unit CTest passed. - HRR integration and `hrr-playback` build passed locally with HIP compiler setup. - hip-tests `Unit_HRR_CaptureSmoke` passed locally. ## Pending / follow-up - Full CLR `amdhip64` build needs a matching ROCm/HSA toolchain; the local attempt hit an unrelated HSA header mismatch. - HRR integration runtime parity/datacenter validation remains environment-dependent. - TheRock orchestration/packaging is paired in ROCm/TheRock#7669. - Runtime capture relocation remains intentionally out of scope for this PR. ## Related - ROCm/TheRock#7669 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Daniel Olsson <Daniel.Olsson@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
anugodavar
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Sep 17, 2026
## Summary - Move HRR portable layer (wire format, playback, generator, docs, skills, tests) to `projects/hrr`. - Keep runtime capture in CLR and add a hip-tests capture smoke sentinel. - Add HRR label/CODEOWNERS metadata and update docs/skills for standalone playback builds. - Add build-only TheRock CI matrix coverage for `projects/hrr` changes and make GPU integration tests explicit opt-in. ## Validation - Static checks: no flat `hrr_api_args.h` includes; no stale old playback paths; no conflict markers or pycache artifacts. - TheRock CI matrix tests: 32 passed. - HRR script tests: 24 passed. - Generator idempotency: checksum-stable. - HRR unit CTest passed. - HRR integration and `hrr-playback` build passed locally with HIP compiler setup. - hip-tests `Unit_HRR_CaptureSmoke` passed locally. ## Pending / follow-up - Full CLR `amdhip64` build needs a matching ROCm/HSA toolchain; the local attempt hit an unrelated HSA header mismatch. - HRR integration runtime parity/datacenter validation remains environment-dependent. - TheRock orchestration/packaging is paired in ROCm/TheRock#7669. - Runtime capture relocation remains intentionally out of scope for this PR. ## Related - ROCm/TheRock#7669 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Daniel Olsson <Daniel.Olsson@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
mangupta
force-pushed
the
hrr-orchestration
branch
from
September 17, 2026 14:17
4bc2949 to
4d4fa88
Compare
Contributor
Author
|
Fixed the latest CI bookkeeping failures in commit
These address the Consumer Graph Drift and Validate Artifact Structure failures. The unrelated JAX/rocprofiler test failures are not caused by this PR. |
Register HRR orchestration, packaging, and consumer graph coverage without changing the rocm-systems submodule pointer.\n\nCo-Authored-By: Claude <noreply@anthropic.com>
mangupta
force-pushed
the
hrr-orchestration
branch
from
September 18, 2026 08:24
5829f87 to
664c051
Compare
Contributor
Author
|
Reworked the branch so the PR no longer changes the The branch was reset to current TheRock main and rebuilt with only these five files:
The submodule pointer is inherited unchanged from current TheRock main ( |
Regenerate the remaining hrr consumer edge and declare the lib artifact component so artifact structure validation covers every core-hrr component.\n\nCo-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Addressed the two remaining bookkeeping failures in commit
JSON/TOML validation and the consumer graph drift check pass locally. The unrelated JAX/rocprofiler failures remain outside this PR. |
nunnikri
reviewed
Sep 18, 2026
| { | ||
| "Name": "hrr", | ||
| "Components": [ | ||
| "lib", |
Contributor
There was a problem hiding this comment.
Isnt lib supposed to be part of runtime package and not test package?
Contributor
There was a problem hiding this comment.
Yes. lib is the shared-library slice, so it belongs on amdrocm-runtime next to run, same as core-hip.
| "Name": "hrr", | ||
| "Components": [ | ||
| "dev", | ||
| "doc" |
Contributor
There was a problem hiding this comment.
doc is already in runtime package. For now its empty so its not creating any conflict. But in future if any files are added it can create duplicate files and create conflict at installation
Contributor
There was a problem hiding this comment.
Yes. I too suggest dropping doc from amdrocm-runtime-devel and leave it only on the runtime package, matching core-hip.
| { | ||
| "Name": "hrr", | ||
| "Components": [ | ||
| "doc", |
Contributor
There was a problem hiding this comment.
Doc component is empty. Are these modules distributed under same license as hip? Isnt it better to have seperate License file for hrr?
Contributor
There was a problem hiding this comment.
Same license as HIP (MIT). A separate LICENSE file is optional; We can add one if you want it in that component.
Contributor
|
@mangupta there is no documentation of how to enable hip replay or how to use the output. Can we add that(may be in rocm-systems) and link that in TheRock docs as well? |
Contributor
Author
@nunnikri : HRR is already part of ROCm since 10.0 I believe. All this PR and the rocm-systems PR is doing is to move it out of CLR project into its own project so that HRR developers don't need to look for HIP runtime team for code approvals. If you need any details of this you can check with @danielbolsson or @rainayera . |
Contributor
We have a PR adding HRR documentation in rocm-systems that has been waiting for review approval for over a month now: |
|
Looked at this from the HRR side. The build and packaging wiring look right to me. I opened AIRUNTIME-2810 to track it. A few questions:
On the clean CI ask: the 13 red checks are all in other projects (tensilelite, rocprim, rocsparse, hipsparselt, rocprofiler, hipdnn, rocjpeg, the JAX wheels, two FFT tests on Windows), plus the description bot. Nothing points at this change. Not sure a clean run is reachable at all here. What do you normally do when the red is all elsewhere? |
This was referenced Sep 26, 2026
danielbolsson
left a comment
danielbolsson
left a comment
Contributor
There was a problem hiding this comment.
Two packaging adjustments so core-hrr matches core-hip. Each note has a suggestion that can be applied directly. Apply all three together.
Comment on lines
+256
to
+259
| "Components": [ | ||
| "doc", | ||
| "run" | ||
| ] |
Contributor
There was a problem hiding this comment.
lib is the shared-library component, so it belongs on this runtime package with run, same as core-hip. It is empty today.
Suggested change
| "Components": [ | |
| "doc", | |
| "run" | |
| ] | |
| "Components": [ | |
| "lib", | |
| "run", | |
| "doc" | |
| ] |
Comment on lines
+344
to
+347
| "Components": [ | ||
| "dev", | ||
| "doc" | ||
| ] |
Contributor
There was a problem hiding this comment.
doc is already on the runtime package. Listing it here too would install the same files twice once share/doc/** has content. core-hip keeps doc on the runtime package only.
Suggested change
| "Components": [ | |
| "dev", | |
| "doc" | |
| ] | |
| "Components": [ | |
| "dev" | |
| ] |
Comment on lines
+433
to
+436
| "Components": [ | ||
| "lib", | ||
| "test" | ||
| ] |
Contributor
There was a problem hiding this comment.
Drop lib here once it is on the runtime package. This package should keep test only.
Suggested change
| "Components": [ | |
| "lib", | |
| "test" | |
| ] | |
| "Components": [ | |
| "test" | |
| ] |
Comment on lines
+252
to
264
| "Artifact": "core-hrr", | ||
| "Artifact_Subdir": [ | ||
| { | ||
| "Name": "hrr", | ||
| "Components": [ | ||
| "doc", | ||
| "run" | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Artifact": "amd-llvm", |
Contributor
There was a problem hiding this comment.
hrr-playback is a replay and inspection tool. A HIP application does not load it to run, so this run slice should not ship in amdrocm-runtime.
Package it the way rocgdb is pulled in: its own package, depended on by the amdrocm-developer-tools metapackage. Leave it out of amdrocm-debugger (different product, license, and maintainer). Keep core-hrr in the CORE feature group with its core-hip dependency, so the binary is still built in the same TheRock run as the capture runtime inside amdhip64. artifact-core-hrr.toml and the hip-tests runtime dependency can stay. include/hrr/** is a single dev slice, so hrr_regions.h and the playback headers travel with this package.
amdrocm-runtime-test currently reaches the binary only because amdrocm-runtime-devel depends on amdrocm-runtime. After this move, add amdrocm-hrr to the test package dependencies. The lib and test slices are empty and can drop off amdrocm-runtime-test.
diff --git a/build_tools/packaging/linux/package.json b/build_tools/packaging/linux/package.json
--- a/build_tools/packaging/linux/package.json
+++ b/build_tools/packaging/linux/package.json
@@ -249,18 +249,6 @@
}
]
},
- {
- "Artifact": "core-hrr",
- "Artifact_Subdir": [
- {
- "Name": "hrr",
- "Components": [
- "doc",
- "run"
- ]
- }
- ]
- },
{
"Artifact": "amd-llvm",
@@ -337,18 +325,6 @@
}
]
},
- {
- "Artifact": "core-hrr",
- "Artifact_Subdir": [
- {
- "Name": "hrr",
- "Components": [
- "dev",
- "doc"
- ]
- }
- ]
- },
{
"Artifact": "core-kpack",
@@ -392,6 +368,8 @@
"DEBDepends": [
"amdrocm-runtime-devel",
+ "amdrocm-hrr",
"amdrocm-sysdeps",
@@ -398,6 +376,7 @@
"RPMRequires": [
"amdrocm-runtime-devel",
+ "amdrocm-hrr",
"amdrocm-sysdeps",
@@ -426,18 +405,6 @@
}
]
},
- {
- "Artifact": "core-hrr",
- "Artifact_Subdir": [
- {
- "Name": "hrr",
- "Components": [
- "lib",
- "test"
- ]
- }
- ]
- },
{
"Artifact": "rocrtst",
@@ -3796,6 +3763,46 @@
"Gfxarch": "False"
},
+ {
+ "Package": "amdrocm-hrr",
+ "Version": "",
+ "Architecture": "amd64",
+ "BuildArch": "x86_64",
+ "DEBDepends": [
+ "amdrocm-runtime"
+ ],
+ "RPMRequires": [
+ "amdrocm-runtime"
+ ],
+ "Maintainer": "ROCm Dev Support <rocm-dev.support@amd.com>",
+ "Description_Short": "HIP record and replay playback tool",
+ "Description_Long": "hrr-playback replays HIP captures produced by the HRR capture runtime in amdhip64. Provides archive inspection, replay, and device-to-host validation for debugging GPU workloads. Installs the playback binary and HRR headers.",
+ "Section": "devel",
+ "Priority": "optional",
+ "Group": "unknown",
+ "License": "MIT",
+ "Vendor": "Advanced Micro Devices, Inc",
+ "Homepage": "https://github.com/ROCm/rocm-systems",
+ "Artifactory": [
+ {
+ "Artifact": "core-hrr",
+ "Artifact_Subdir": [
+ {
+ "Name": "hrr",
+ "Components": [
+ "run",
+ "dev",
+ "doc"
+ ]
+ }
+ ]
+ }
+ ],
+ "Gfxarch": "False"
+ },
{
"Package": "amdrocm-developer-tools",
@@ -3808,7 +3815,8 @@
"amdrocm-profiler-base",
"amdrocm-profiler",
"amdrocm-emulation",
- "amdrocm-debugger"
+ "amdrocm-debugger",
+ "amdrocm-hrr"
],
"RPMRequires": [
@@ -3817,7 +3825,8 @@
"amdrocm-profiler-base",
"amdrocm-profiler",
"amdrocm-emulation",
- "amdrocm-debugger"
+ "amdrocm-debugger",
+ "amdrocm-hrr"
],The wheel allowlist and the Windows MSI are separate channels. This PR does not put hrr-playback in either, and that matches rocgdb being absent from the MSI.
1 task done
danielbolsson
added a commit
that referenced
this pull request
Oct 28, 2026
…8965) ## Motivation HIP Record and Replay (HRR) captures HIP API calls from inside `amdhip64` and replays them with `hrr-playback`. Since HRR moved out of CLR into `rocm-systems/projects/hrr` (ROCm/rocm-systems#11157), TheRock no longer builds or ships `hrr-playback`. This PR: - builds `hrr-playback` as a new `hrr` subproject and `core-hrr` artifact, and packages it as `amdrocm-hrr`; - maps `projects/hrr` to an artifact, so a rocm-systems PR that touches only HRR builds one stage instead of all of them. With rocm-systems' `.github/scripts/compute_build_stages.py --changed-projects projects/hrr`, current `main` logs `Unrecognized project(s) ['hrr'] -> build all stages`. With this branch it selects `compiler-runtime` only and skips Windows (`windows_amdgpu_families=none`), because `core-hrr` is Linux-only; - adds a testing-only `hrr-capture` build variant. Release `amdhip64` compiles capture out, so HRR's GPU tests need a separate build. The variant is the release build plus a `HIP_HRR_CAPTURE` flag; release builds and their artifacts are unchanged. This supersedes #7669 by @mangupta. His two commits are cherry-picked with his authorship, followed by the corrections below. JIRA ID : AIRUNTIME-2871 ## Technical Details **Build and packaging (from #7669, corrected)** - `core-hrr`: `hip-runtime` group, target-neutral, depends on `core-hip`, components `run` (`bin/hrr-playback`), `dev` (`include/hrr`), `dbg` and `doc`. - `core-hrr` is disabled on Windows (`disable_platforms = ["windows"]`). Nothing uses `hrr-playback` there: `amdrocm-hrr` is a Linux package, and no Windows build compiles capture into `amdhip64`. Windows builds and tarballs therefore have no `hrr-playback.exe`. - The subproject builds playback only (`HRR_BUILD_TESTS=OFF`, no catch2). The HRR test suites are not installable yet, and the integration suite needs a capture-enabled `amdhip64`. - Dropped from #7669: the `rocjitsu`/`mirage` `artifact_deps` change (unrelated), the `core-hiptests -> core-hrr` edge and the `hip-tests` runtime dependency on `hrr` (the hip-tests HRR smoke test does not run `hrr-playback`), and the empty `lib`/`test` components. - New `amdrocm-hrr` package (`run`, `dev`, `doc`; depends on `amdrocm-runtime`; MIT). `amdrocm-developer-tools` depends on it, as it does on `amdrocm-debugger`. Nothing is added to `amdrocm-runtime*`. - `install_rocm_from_artifacts.py --hrr` installs `core-hrr_run`. - Regenerated `test_tools/therock_consumer_graph.json` and added `core-hrr` to `build_tools/artifact_subprojects.json`. **`HIP_HRR_CAPTURE` flag and `hrr-capture` variant** - `FLAGS.cmake`: `HIP_HRR_CAPTURE`, default `OFF`, adds `HIP_HRR_CAPTURE_ENABLED=1` to `hip-clr`. That is the definition CLR's capture code checks today. `flags.md` recommends `ROCMBuildFlags.cmake` plus a private header for new C/C++ consumers. CLR has no such consumer yet, so this uses the scoped `CPP_DEFINES` path, as `HSA_HOTSWAP_DEFAULT_ON` does for ROCR-Runtime. It can switch once CLR resolves the flag itself. - `CMakePresets.json`: `linux-release-hrr-capture` (Release plus the flag). - `amdgpu_family_matrix.py`: an `hrr-capture` Linux variant with suffix `hrr-capture` (artifact group `multi-arch-hrr-capture`). The name avoids `san`, which `select_build_runner` routes to sanitizer runners. It is listed for gfx90a, gfx94x, gfx950, gfx103x, gfx110x, gfx1150, gfx1151, gfx1153, gfx120x and gfx125x. - No workflow selects the variant yet. `configure_multi_arch_ci.py` needs no special case: families are filtered by `build_variants`, and tests follow the normal trigger rules. **CI path handling** TheRock's CI code has no HRR-specific path rules. rocm-systems lists its HRR workflows, and the HRR paths TheRock never reads (`projects/hrr/tests`, `tools`, `skills`), in its own `.github/skip-ci-config.toml` ([ROCm/rocm-systems#13256](ROCm/rocm-systems#13256)). `configure_multi_arch_ci.py` already reads that file, so a rocm-systems PR that changes only those paths skips TheRock CI. An earlier revision of this PR changed other things that are no longer here: - it aliased those workflows to `projects/hrr` in `configure_external_repo_ci.py`; - it passed external-repo changed files into stage reuse and narrowed the rebuilt stages. The stage-reuse part changes reuse for every external repo, and it needs its own design review. It made no difference for HRR-only changes, because rocm-systems already limits those to `compiler-runtime` through `build_stages`. **Dependency added** - License: MIT (SPDX headers in `projects/hrr`). - Owner: `@ROCm/hrr-reviewers`, the code owners of `projects/hrr` in rocm-systems. - Build impact: host-only C++ with no device code. Built locally, playback is 5 C++ objects that compile in about 4 s with `-j4`; `hrr-playback` is 0.9 MB (0.7 MB stripped). **Follow-ups, not in this PR** - A `core-hrrtests` artifact once `projects/hrr` installs its test binaries and configs so their paths resolve from the installed tree. - A `test_hrr` component in `fetch_test_configurations.py`, following `miopen-dbsync`: `linux_cpu_runner: True` and `test_types`, running the suite under rocJITsu. That uses CPU runners, so it needs no GPU-runner capacity plan. - A caller for the `hrr-capture` variant, which nothing selects yet. It would request `build_variant: hrr-capture` with `build_stages` limited to `compiler-runtime`. Release builds stay unchanged, and that request does not rebuild `math-libs`. - Until those land, rocm-systems HRR CI keeps building its own capture-enabled `amdhip64` on top of TheRock release artifacts. ## Test Plan - Unit tests: `build_tools/tests/install_rocm_from_artifacts_test.py`, `build_tools/github_actions/tests/configure_multi_arch_ci_test.py`, `amdgpu_family_matrix_test.py` and `check_consumer_graph_drift_test.py`. New tests: - `--hrr` installs `core-hrr_run`; - `hrr-capture` selects only Linux families that list it, uses its preset and suffix, and keeps presubmit test runners; - every listed variant is defined, and every variant preset exists in `CMakePresets.json`. Removing the new preset makes this test fail. - `build_tools/tests/configure_external_repo_ci_test.py`: a `therock*` workflow change on rocm-systems runs all tests. That test was added in an earlier revision and is kept, because no other test reaches that branch. - All of `build_tools/tests`, `build_tools/github_actions/tests` and `test_tools/tests`. - `fetch_sources.py`, then a full configure (`-DTHEROCK_ENABLE_ALL=ON -DTHEROCK_AMDGPU_FAMILIES=gfx94X-dcgpu`) in the pinned manylinux build image, then `check_consumer_graph_drift.py --check`. - `generate_subproject_manifest.py --verify` and `build_tools/tests/configure_stage_test.py` in the same image, on this branch and on `main`. - `compute_build_stages.py --changed-projects projects/hrr` from rocm-systems against `main` and this branch. - `pre-commit` on the changed files; bandit with `build_tools/scan_tools/bandit.yml`. ## Test Result - Unit tests from the earlier local run (install, family matrix, consumer graph, and `configure_multi_arch_ci` as it was then): 205 passed, 1 skipped (an existing skip). - At the head of this branch, `build_tools/tests`, `build_tools/github_actions/tests` and `test_tools/tests`: 2372 passed, 17 skipped. Two files were left out because they also fail on `main` on the test machine (host ASAN runtime and stub compilation): `exe_stub_gen_test.py` and `configure_asan_env_test.py`. - Configure succeeds and reports `HIP_HRR_CAPTURE = OFF` and `CORE_HRR` enabled. The consumer graph is up to date. - The committed `artifact_subprojects.json` is already stale on `main`: it predates several artifacts, and the generator now writes a different layout. This PR adds only the `core-hrr` entry rather than regenerating the whole file. As a result, `configure_stage_test.py` has the same single failure (`test_artifact_subprojects_matches_cmake`) on this branch as on `main`, with 15 passed. CI skips that test when submodules are not fetched. - `compute_build_stages.py`: all stages on `main`. On this branch, `compiler-runtime` only, with `windows_amdgpu_families=none`. - The configure and consumer-graph results above predate the Linux-only change. The Linux graph does not depend on Windows availability, and this PR's consumer graph drift check covers it. - `pre-commit` and bandit: clean. - Not run locally: a full TheRock build of the `hrr` subproject, or a build with the `hrr-capture` preset. TheRock CI covers the first. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md. --------- Signed-off-by: Daniel Olsson <daniel.olsson@amd.com> Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core-hrrartifact packaging forhrr-playbackand HRR headers.core-hiptestsdepend oncore-hrrso packaged tests have HRR tooling available.projects/hrrchanges through the rocm-systems runtimes CI matrix with a build-only HRR configuration.rocm-systemsgitlink to the current mainline commit containing the merged HRR migration.Related
Validation
BUILD_TOPOLOGY.toml,core/artifact-core-hrr.toml, Linuxpackage.json, andtest_tools/therock_consumer_graph.json.Pending
🤖 Generated with Claude Code