[ci] Reorganizing artifact upload #730
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| upload_build_artifacts.py | ||
|
|
||
| Uploads build artifacts to AWS S3 bucket | ||
| """ | ||
|
|
||
| import argparse | ||
| import logging | ||
| import os | ||
| from pathlib import Path | ||
| import platform | ||
| import shlex | ||
| import subprocess | ||
| import sys | ||
|
|
||
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
| THEROCK_DIR = Path(__file__).resolve().parent.parent.parent | ||
| PLATFORM = platform.system().lower() | ||
|
|
||
| # Importing indexer.py | ||
| sys.path.append(str(THEROCK_DIR / "third-party" / "indexer")) | ||
| from indexer import process_dir | ||
|
|
||
|
|
||
| def exec(cmd: list[str], cwd: Path): | ||
| logging.info(f"++ Exec [{cwd}]$ {shlex.join(cmd)}") | ||
| subprocess.run(cmd, check=True) | ||
|
|
||
|
|
||
| def retrieve_bucket_info() -> tuple[str, str]: | ||
| github_repository = os.getenv("GITHUB_REPOSITORY", "ROCm/TheRock") | ||
| owner, repo_name = github_repository.split("/") | ||
| external_repo = ( | ||
| "" if repo_name == "TheRock" and owner == "ROCm" else f"{owner}-{repo_name}/" | ||
| ) | ||
| bucket = ( | ||
| "therock-artifacts" | ||
| if repo_name == "TheRock" and owner == "ROCm" | ||
| else "therock-artifacts-external" | ||
| ) | ||
| return (external_repo, bucket) | ||
|
|
||
|
|
||
| def create_index_file(args: argparse.Namespace): | ||
| logging.info("Creating index file") | ||
| build_dir = args.build_dir / "artifacts" | ||
|
|
||
| indexer_args = argparse.Namespace() | ||
| indexer_args.filter = "*.tar.xz*" | ||
| indexer_args.output_file = "index.html" | ||
| indexer_args.verbose = False | ||
| indexer_args.recursive = False | ||
| process_dir(build_dir, indexer_args) | ||
|
|
||
|
|
||
| def upload_artifacts(args: argparse.Namespace, bucket_uri: str): | ||
| logging.info("Uploading artifacts to S3") | ||
| build_dir = args.build_dir | ||
| amdgpu_family = args.amdgpu_family | ||
|
|
||
| # Uploading artifacts to S3 bucket | ||
| cmd = [ | ||
| "aws", | ||
| "s3", | ||
| "cp", | ||
| str(build_dir / "artifacts"), | ||
| bucket_uri, | ||
| "--recursive", | ||
| "--no-follow-symlinks", | ||
| "--exclude", | ||
| "*", | ||
| "--include", | ||
| "*.tar.xz*", | ||
| ] | ||
| exec(cmd, cwd=Path.cwd()) | ||
|
|
||
| # Uploading index.html to S3 bucket | ||
| cmd = [ | ||
| "aws", | ||
| "s3", | ||
| "cp", | ||
| str(build_dir / "artifacts" / "index.html"), | ||
| f"{bucket_uri}/index-{amdgpu_family}.html", | ||
| ] | ||
| exec(cmd, cwd=Path.cwd()) | ||
|
|
||
|
|
||
| def run(args: argparse.Namespace): | ||
| external_repo_path, bucket = retrieve_bucket_info() | ||
| run_id = args.run_id | ||
| bucket_uri = f"s3://{bucket}/{external_repo_path}{run_id}-{PLATFORM}" | ||
|
|
||
| create_index_file(args) | ||
| upload_artifacts(args, bucket_uri) | ||
|
|
||
|
|
||
| def main(argv): | ||
| parser = argparse.ArgumentParser(prog="artifact_upload") | ||
| parser.add_argument( | ||
| "--run-id", type=str, required=True, help="GitHub run ID of this workflow run" | ||
| ) | ||
|
|
||
| parser.add_argument( | ||
| "--amdgpu-family", type=str, required=True, help="AMD GPU family to upload" | ||
| ) | ||
|
|
||
| parser.add_argument( | ||
| "--build-dir", | ||
| type=Path, | ||
| required=True, | ||
| help="Path to the build directory of TheRock", | ||
| ) | ||
|
|
||
| args = parser.parse_args(argv) | ||
| run(args) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main(sys.argv[1:]) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this after the testing is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these
ref:changes even needed on this PR itself? I'm a bit confused about the sequencing here. Prefer to keep test changes out of PRs so we can accurately review the changes as they will be merged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it is not! i just added it for testing purposes to have it in
rocm-libraries. i'll remove it now and have this run through