Skip to content

Bump rocm-systems from d22b864 to 1ec2020 - #7031

Merged
amd-chiranjeevi merged 2 commits into
mainfrom
bump-rocm-systems-1ec2020
Aug 1, 2026
Merged

Bump rocm-systems from d22b864 to 1ec2020#7031
amd-chiranjeevi merged 2 commits into
mainfrom
bump-rocm-systems-1ec2020

Conversation

@systems-assistant

@systems-assistant systems-assistant Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@systems-assistant systems-assistant Bot added the ci:run-all-archs Opt-in to building for all architectures on a pull request label Jul 31, 2026
@systems-assistant
systems-assistant Bot requested a review from a team as a code owner July 31, 2026 17:19
@therock-pr-bot

therock-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🤖 Bump PR detected (author @systems-assistant[bot]). All policy checks are auto-approved for automated dependency bumps.

@araravik-psd
araravik-psd self-requested a review July 31, 2026 17:22
@therock-pr-bot

therock-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🤖 Bump PR detected (author @systems-assistant[bot]). All policy checks are auto-approved for automated dependency bumps.

araravik-psd
araravik-psd reviewed Jul 31, 2026
View reviewed changes

@araravik-psd araravik-psd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux build and tests have gone through, waiting for windows build math libs stage on 90a, Approving the PR and we can be bumped once windows build passes too

ScottTodd
ScottTodd approved these changes Jul 31, 2026
View reviewed changes

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good. Ideally we should wait until the Windows build and tests complete. Given that it is Friday afternoon, merging any time prior to Monday morning is what mostly matters to keep the train moving, but merging ahead of tonight's 5PM release build would be ideal if possible.

araravik-psd
araravik-psd approved these changes Jul 31, 2026
View reviewed changes

@araravik-psd araravik-psd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, will merge in an hour even if tests don’t finish

@araravik-psd

araravik-psd commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Few windows test failures seen. Failures look flaky or infra related. Will need to re-run to confirm if issues resolve

@amd-chiranjeevi
amd-chiranjeevi merged commit d4680c2 into main Aug 1, 2026
2918 of 2978 checks passed
@amd-chiranjeevi
amd-chiranjeevi deleted the bump-rocm-systems-1ec2020 branch August 1, 2026 06:19
mdnaveedh added a commit that referenced this pull request Nov 5, 2026
@mdnaveedh
Drop expired rocm-systems patches
6e45bab 
Both were carried in #7007 until the submodule pin caught up and were
removed from main in #7031. The pin is now 1420d37, so 0001 fails to
apply and breaks fetch_sources.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes
@marbre marbre Awaiting requested review from marbre marbre is a code owner
@skganesan008 skganesan008 Awaiting requested review from skganesan008 skganesan008 is a code owner
+1 more reviewer
@araravik-psd araravik-psd araravik-psd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci:run-all-archs Opt-in to building for all architectures on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@araravik-psd @ScottTodd @amd-chiranjeevi @aravind-ravi1206