Skip to content

feat(build): add THEROCK_COMGR_DLL_NAME to override comgr DLL name #6971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lamb-j merged 2 commits into from
Jul 31, 2026
Merged

feat(build): add THEROCK_COMGR_DLL_NAME to override comgr DLL name #6971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75084a
feat(build): add THEROCK_COMGR_DLL_NAME to override comgr DLL name
lamb-j Jul 29, 2026
258af9b
Apply suggestion from @lamb-j
lamb-j Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ option(THEROCK_BUILD_LLVM_TOOLS "Enables building all LLVM tools (not just minim
option(THEROCK_BUILD_LLVM_TESTS "Enables building LLVM LIT tests" OFF)
option(THEROCK_ENABLE_HOTSWAP "Enables the comgr hotswap transpiler/tool and loads it in the runtime via HSA_TOOLS_LIB" ON)
option(THEROCK_USE_NEW_HOSTCALL_IMPL "Use the new phase/occupancy-based hostcall implementation in device-libs and clr" OFF)
set(THEROCK_COMGR_DLL_NAME "" CACHE STRING "Override the Comgr DLL name for the comgr build and CLR load (e.g. amd_comgr_opencl.dll); empty = component default")

set(THEROCK_SANITIZER "" CACHE STRING "Enable project wide sanitizer build ('ASAN' for host+device, 'HOST_ASAN' for host-only)")

Expand Down
8 changes: 8 additions & 0 deletions compiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,13 @@ if(THEROCK_ENABLE_COMPILER)
endif()
endif()

# Optionally override the comgr DLL/shared-library output name (Windows). Kept
# in sync with the CLR load side via the same THEROCK_COMGR_DLL_NAME option.
set(_comgr_dll_name_cmake_args)
if(THEROCK_COMGR_DLL_NAME)
list(APPEND _comgr_dll_name_cmake_args "-DCOMGR_DLL_NAME=${THEROCK_COMGR_DLL_NAME}")
endif()

therock_cmake_subproject_declare(amd-comgr
USE_DIST_AMDGPU_TARGETS
NO_INSTALL_RPATH # See manual handling in the pre_hook.
Expand All @@ -201,6 +208,7 @@ if(THEROCK_ENABLE_COMPILER)
"-DLLVM_VERSION_SUFFIX=-rocm${ROCM_MAJOR_VERSION}"
-DLLVM_ENABLE_SYMBOL_VERSIONING=ON
${_comgr_hotswap_cmake_args}
${_comgr_dll_name_cmake_args}
BUILD_DEPS
rocm-cmake
${_comgr_gtest_deps}
Expand Down
9 changes: 9 additions & 0 deletions core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,14 @@ if(THEROCK_ENABLE_HIP_RUNTIME)
)
endif()

# Optionally override the comgr DLL name that CLR dynamically loads (Windows).
# Kept in sync with the comgr build side via the same THEROCK_COMGR_DLL_NAME
# option, so the name CLR loads matches the name comgr is built as.
set(_clr_comgr_dll_name_cmake_args)
if(THEROCK_COMGR_DLL_NAME)
list(APPEND _clr_comgr_dll_name_cmake_args "-DCOMGR_DLL_NAME=${THEROCK_COMGR_DLL_NAME}")
endif()



therock_cmake_subproject_declare(hip-clr
Expand All @@ -292,6 +300,7 @@ if(THEROCK_ENABLE_HIP_RUNTIME)
"-DCLR_BUILD_HIP=ON"
"-DROCM_KPACK_ENABLED=ON"
"-DUSE_NEW_HOSTCALL_IMPL=${THEROCK_USE_NEW_HOSTCALL_IMPL}"
${_clr_comgr_dll_name_cmake_args}
# Legacy: Disable various auto-detection logic that breaks out of jail
# and can use local machine tools.
"-DHIPCC_BIN_DIR="
Expand Down
Loading