fix(ci): Address PR review comments

7f623d2

Select commit

Loading

Failed to load commit list.

Uh oh!

There was an error while loading. Please reload this page.

TheRock PR Bot on: pull_request_target 1

therock-pr-bot

CodeQL on: pull_request

Analyze (python)

Analyze (actions)

Unit Tests on: pull_request

Unit Tests :: ubuntu-24.04

Unit Tests :: windows-2022

Unit Tests Summary

pre-commit on: pull_request 2

pre-commit

Pre commit security on: pull_request

gitleaks / Gitleaks scan

Multi-Arch CI on: pull_request 69

setup / setup

Manifest Diff / Generate Manifest Diff Report

Linux::release / Copy Prebuilt Stages

Linux::release / Build Multi-Arch Stages / compiler-runtime / Stage - Compiler Runtime

Linux::release / Build Multi-Arch Stages / runtime-tests / Stage - Runtime Tests

Linux::release / Build Multi-Arch Stages / wsl-rocdxg / Stage - WSL ROCDXG

Linux::release / Build Multi-Arch Stages / math-libs (gfx94X-dcgpu, gfx942, linux-gfx942-1gpu-ccs-csp-ossci-rocm, false, linux-gfx942-1gpu-c... / Stage - Math Libs (gfx94X-dcgpu)

Linux::release / Build Multi-Arch Stages / math-libs (gfx110X-all, false) / Stage - Math Libs (gfx110X-all)

Linux::release / Build Multi-Arch Stages / math-libs (gfx1151, gfx1151, false) / Stage - Math Libs (gfx1151)

Linux::release / Build Multi-Arch Stages / math-libs (gfx120X-all, gfx1200,gfx1201, false) / Stage - Math Libs (gfx120X-all)

Linux::release / Build Multi-Arch Stages / math-libs (gfx125X-dcgpu, false) / Stage - Math Libs (gfx125X-dcgpu)

Linux::release / Build Multi-Arch Stages / comm-libs / Stage - Comm Libs

Linux::release / Build Multi-Arch Stages / storage-libs / Stage - Storage Libs

Linux::release / Build Multi-Arch Stages / debug-tools / Stage - Debug Tools

Linux::release / Build Multi-Arch Stages / dctools-core / Stage - DC Tools Core

Linux::release / Build Multi-Arch Stages / profiler-apps / Stage - Profiler Apps

Linux::release / Build Multi-Arch Stages / media-libs / Stage - Media Libs

Linux::release / Validate Artifact Structure / Validate artifact structure

Linux::release / Test gfx94X-dcgpu / Configure test matrix (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test Sanity Check / Test sanity (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hip-tests / Test hip-tests (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipfile / Test hipfile (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocblas / Test rocblas (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocroller / Test rocroller (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test tensilelite / Test tensilelite (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipblas / Test hipblas (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test amdsmi / Test amdsmi (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipblaslt / Test hipblaslt (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipsolver / Test hipsolver (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocsolver / Test rocsolver (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocprim / Test rocprim (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipcub / Test hipcub (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocgdb-cpu / Test rocgdb-cpu (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocgdb-gpu / Test rocgdb-gpu (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocr-debug-agent / Test rocr-debug-agent (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocthrust / Test rocthrust (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipsparse / Test hipsparse (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocsparse / Test rocsparse (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipsparselt / Test hipsparselt (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocrand / Test rocrand (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hiprand / Test hiprand (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocfft / Test rocfft (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipfft / Test hipfft (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test miopen / Test miopen (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rccl / Test rccl (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocprofiler-sdk / Test rocprofiler-sdk (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipdnn / Test hipdnn (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipdnn_install / Test hipdnn_install (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipdnn-integration-tests / Test hipdnn-integration-tests (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipdnn-samples / Test hipdnn-samples (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test miopenprovider / Test miopenprovider (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipblasltprovider / Test hipblasltprovider (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hipkernelprovider / Test hipkernelprovider (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocwmma / Test rocwmma (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocalution / Test rocalution (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocprofiler-compute / Test rocprofiler-compute (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocprofiler-systems / Test rocprofiler-systems (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test libhipcxx_hipcc / Test libhipcxx_hipcc (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test libhipcxx_hiprtc / Test libhipcxx_hiprtc (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocdecode / Test rocdecode (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocjpeg / Test rocjpeg (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test aqlprofile / Test aqlprofile (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test rocrtst / Test rocrtst (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx94X-dcgpu / Test hiptensor / Test hiptensor (shard 1/1) (gfx94X-dcgpu)

Linux::release / Test gfx110X-all / Configure test matrix (${{ inputs.amdgpu_families }})

Linux::release / Test gfx110X-all / Test Sanity Check

Linux::release / Test gfx110X-all / Test ${{ matrix.components.job_name }}

Linux::release / Test gfx1151 / Configure test matrix (${{ inputs.amdgpu_families }})

Linux::release / Test gfx1151 / Test Sanity Check

Linux::release / Test gfx1151 / Test ${{ matrix.components.job_name }}

Linux::release / Test gfx120X-all / Configure test matrix (${{ inputs.amdgpu_families }})

Linux::release / Test gfx120X-all / Test Sanity Check

Linux::release / Test gfx120X-all / Test ${{ matrix.components.job_name }}

Linux::release / Test gfx125X-dcgpu / Configure test matrix (${{ inputs.amdgpu_families }})

Linux::release / Test gfx125X-dcgpu / Test Sanity Check

Linux::release / Test gfx125X-dcgpu / Test ${{ matrix.components.job_name }}

Linux::release / Build DEB Packages / Build deb packages

Linux::release / Build RPM Packages / Build rpm packages

Linux::release / Build Python Packages / Build Python | multi-arch-release

Linux::release / Test DEB Install - ubuntu2404 / Prepare install context (package type, GPU arch, container image)

Linux::release / Test DEB Install - ubuntu2404 / Test Native Linux Packages Installation - ubuntu2404

Linux::release / Test RPM Install - rhel8 / Prepare install context (package type, GPU arch, container image)

Linux::release / Test RPM Install - rhel8 / Test Native Linux Packages Installation - rhel8

Linux::release / Test RPM Install - rhel10 / Prepare install context (package type, GPU arch, container image)

Linux::release / Test RPM Install - rhel10 / Test Native Linux Packages Installation - rhel10

Linux::release / Test RPM Install - sles16 / Prepare install context (package type, GPU arch, container image)

Linux::release / Test RPM Install - sles16 / Test Native Linux Packages Installation - sles16

Linux::release / Test Python (gfx94X-dcgpu, linux-gfx942-1gpu-ccs-csp-ossci-rocm, 3.10, ubuntu24.04, ghcr.io/rocm/... / Test ROCm wheels | gfx94X-dcgpu | py3.10 | ubuntu24.04

Linux::release / Test Python (gfx94X-dcgpu, linux-gfx942-1gpu-ccs-csp-ossci-rocm, 3.10, ubi10, ghcr.io/rocm/no_roc... / Test ROCm wheels | gfx94X-dcgpu | py3.10 | ubi10

Linux::release / Test Python (gfx94X-dcgpu, linux-gfx942-1gpu-ccs-csp-ossci-rocm, 3.11, ubuntu24.04, ghcr.io/rocm/... / Test ROCm wheels | gfx94X-dcgpu | py3.11 | ubuntu24.04

Linux::release / Test Python (gfx94X-dcgpu, linux-gfx942-1gpu-ccs-csp-ossci-rocm, 3.11, ubi10, ghcr.io/rocm/no_roc... / Test ROCm wheels | gfx94X-dcgpu | py3.11 | ubi10

Linux::release / Test Python (gfx94X-dcgpu, linux-gfx942-1gpu-ccs-csp-ossci-rocm, 3.12, ubuntu24.04, ghcr.io/rocm/... / Test ROCm wheels | gfx94X-dcgpu | py3.12 | ubuntu24.04

Linux::release / Test Python (gfx94X-dcgpu, linux-gfx942-1gpu-ccs-csp-ossci-rocm, 3.12, ubi10, ghcr.io/rocm/no_roc... / Test ROCm wheels | gfx94X-dcgpu | py3.12 | ubi10

Linux::release / Build PyTorch (fat + split) (3.12, release/2.10, gfx94X-dcgpu;gfx110X-all;gfx1151;gfx120X-all) / Build PyTorch | multi-arch-release | torch release/2.10 | py3.12

Linux::release / Build PyTorch (fat + split) (3.12, release/2.11, gfx94X-dcgpu;gfx110X-all;gfx1151;gfx120X-all;gfx... / Build PyTorch | multi-arch-release | torch release/2.11 | py3.12

Linux::release / Build PyTorch (fat + split) (3.12, release/2.12, gfx94X-dcgpu;gfx110X-all;gfx1151;gfx120X-all) / Build PyTorch | multi-arch-release | torch release/2.12 | py3.12

Linux::release / Build JAX Wheels (3.12, rocm-jaxlib-v0.10.0, ROCm/jax, manylinux, device-all) / Build JAX | multi-arch-release | jax rocm-jaxlib-v0.10.0 | py 3.12

Windows::release / Copy Prebuilt Stages

Windows::release / Build Multi-Arch Stages / compiler-runtime / Stage - Compiler Runtime

Windows::release / Build Multi-Arch Stages / runtime-tests / Stage - Runtime Tests

Windows::release / Build Multi-Arch Stages / math-libs (gfx110X-all, gfx1100,gfx1101,gfx1102,gfx1103, windows-gfx110X-gpu-rocm, false) / Stage - Math Libs (gfx110X-all)

Windows::release / Build Multi-Arch Stages / math-libs (gfx1151, gfx1151, false) / Stage - Math Libs (gfx1151)

Windows::release / Build Multi-Arch Stages / math-libs (gfx120X-all, gfx1200,gfx1201, false) / Stage - Math Libs (gfx120X-all)

Windows::release / Build Multi-Arch Stages / debug-tools / Stage - Debug Tools

Windows::release / Validate Artifact Structure / Validate artifact structure

Windows::release / Test gfx110X-all / Configure test matrix (gfx110X-all)

Windows::release / Test gfx110X-all / Test Sanity Check / Test sanity (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hip-tests (PAL) / Test hip-tests (PAL) (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocblas / Test rocblas (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipblas / Test hipblas (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipblaslt / Test hipblaslt (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipsolver / Test hipsolver (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocprim / Test rocprim (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipcub / Test hipcub (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocthrust / Test rocthrust (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipsparse / Test hipsparse (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocsparse / Test rocsparse (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocrand / Test rocrand (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hiprand / Test hiprand (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipfft / Test hipfft (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test miopen / Test miopen (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipdnn / Test hipdnn (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipdnn_install / Test hipdnn_install (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipdnn-integration-tests / Test hipdnn-integration-tests (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipdnn-samples / Test hipdnn-samples (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test miopenprovider / Test miopenprovider (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipblasltprovider / Test hipblasltprovider (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hipkernelprovider / Test hipkernelprovider (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocwmma / Test rocwmma (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test rocalution / Test rocalution (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test libhipcxx_hipcc / Test libhipcxx_hipcc (shard 1/1) (gfx110X-all)

Windows::release / Test gfx110X-all / Test hiptensor / Test hiptensor (shard 1/1) (gfx110X-all)

Windows::release / Test gfx1151 / Configure test matrix (${{ inputs.amdgpu_families }})

Windows::release / Test gfx1151 / Test Sanity Check

Windows::release / Test gfx1151 / Test ${{ matrix.components.job_name }}

Windows::release / Test gfx120X-all / Configure test matrix (${{ inputs.amdgpu_families }})

Windows::release / Test gfx120X-all / Test Sanity Check

Windows::release / Test gfx120X-all / Test ${{ matrix.components.job_name }}

Windows::release / Build Python Packages / Build Python | multi-arch-release

Windows::release / Test Python (gfx110X-all, windows-gfx110X-gpu-rocm, 3.12, native) / Test ROCm wheels | gfx110X-all | py3.12 | native

Windows::release / Build PyTorch (fat + split) (3.12, release/2.10, gfx110X-all;gfx1151;gfx120X-all) / Build PyTorch | multi-arch-release | torch release/2.10 | py3.12

CI Summary

Multi-Arch CI ASAN on: pull_request

setup / setup

Linux::skip

CI Summary

Code scanning results

CodeQL

GitHub Advanced Security / CodeQL succeeded Jul 21, 2026 in 2s

No new alerts in code changed by this pull request

View all branch alerts.

Loading

Re-running checks...