Skip to content

Bump rocm-systems from 03d8462 to 9e54f75 - #6688

Merged
amd-chiranjeevi merged 1 commit into
mainfrom
bump-rocm-systems-9e54f75
Jul 21, 2026
Merged

Bump rocm-systems from 03d8462 to 9e54f75#6688
amd-chiranjeevi merged 1 commit into
mainfrom
bump-rocm-systems-9e54f75

Conversation

@systems-assistant

@systems-assistant systems-assistant Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@systems-assistant
systems-assistant Bot requested a review from a team as a code owner July 20, 2026 12:47
@systems-assistant systems-assistant Bot added the ci:run-all-archs Opt-in to building for all architectures on a pull request label Jul 20, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

🤖 Bump PR detected (author @systems-assistant[bot]). All policy checks are auto-approved for automated dependency bumps.

@jayhawk-commits jayhawk-commits mentioned this pull request Jul 20, 2026
Closed
@kcossett-amd

kcossett-amd commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I see rocprofiler-systems-pytest-config test is timing out, causing all other tests to not run (test must pass for suite to run). Previously it would print out its results, but it seems with the switch to test_runner.py, that was unintentionally removed.
I'll open a PR to increase timeout and force print on timeout on our side. Hopefully should fix the issue.

Edit 1: Failure observed on GFX950 workflow. GFX942 workflow passes.
Edit 2: I believe re-running the workflow should make it work.

@kcossett-amd kcossett-amd mentioned this pull request Jul 20, 2026
Merged
1 task done
@amd-chiranjeevi

amd-chiranjeevi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Known Issue:
libhipcxx_hipcc: [Issue]: Windows CI: Test libhipcxx_hipcc failing with "error: unsupported HIP gpu architecture" on… → Non-blocker

@amd-chiranjeevi
amd-chiranjeevi self-requested a review July 21, 2026 06:32
amd-chiranjeevi
amd-chiranjeevi approved these changes Jul 21, 2026
View reviewed changes

@amd-chiranjeevi amd-chiranjeevi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failures are known Issues

@amd-chiranjeevi
amd-chiranjeevi merged commit 434f204 into main Jul 21, 2026
1115 of 1148 checks passed
@amd-chiranjeevi
amd-chiranjeevi deleted the bump-rocm-systems-9e54f75 branch July 21, 2026 06:33
@ScottTodd ScottTodd mentioned this pull request Jul 21, 2026
Merged
2 tasks done
kcossett-amd added a commit to ROCm/rocm-systems that referenced this pull request Jul 22, 2026
@kcossett-amd
ci(rocprofiler-systems): Prevent no-log timeouts for the rocprofiler-…
4a9430f 
…systems-pytest-config test (#8863)

## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

TheRock bump PR (ROCm/TheRock#6688) failed (see
https://github.com/ROCm/TheRock/actions/runs/29743540973/job/88374809145?pr=6688)
as `rocprofiler-systems-pytest-config` timed out. Debugging was
impossible as no logs were printed.

This PR aims to change this by printing a stack trace and explicitly
having the test fail.

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

- Increase timeout for `rocprofiler-systems-pytest-config` to 15 seconds
(up from 10)
 - Have a watchdog print out the stack trace.

## Issue Tracking

<!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA
links here. -->
<!-- GitHub issue: #1234 -->
<!-- JIRA ID: EXAMPLECOMPONENT-1234 -->

Jira ID: AIPROFSYST-649

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Local.

## Test Result

<!-- Briefly summarize test outcomes. -->

Locally, when I simulate a hang, I now see:
```
Start testing: Jul 20 13:02 EDT
----------------------------------------------------------
1/621 Testing: rocprofiler-systems-pytest-config
1/621 Test: rocprofiler-systems-pytest-config
Command: "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/bin/pytest" "" "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/rocprof-sys-build/tests/../share/rocprofiler-systems/tests/pytest/" "--show-config-only"
Directory: /home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/rocprof-sys-build/tests
"rocprofiler-systems-pytest-config" start time: Jul 20 13:02 EDT
Output:
----------------------------------------------------------

======================================================================
[rocprofiler-systems-pytest-config] ERROR: configuration probing exceeded 10s and was aborted.
Stack trace at the point of timeout:
----------------------------------------------------------------------
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/bin/pytest", line 8, in <module>
    sys.exit(_console_main())
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 253, in _console_main
    code = _main(prog=_get_prog_name(sys.argv))
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 229, in _main
    ret: ExitCode | int = config.hook.pytest_cmdline_main(config=config)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/pluggy/_hooks.py", line 512, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/pluggy/_callers.py", line 121, in _multicall
    res = hook_impl.function(*args)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/_pytest/main.py", line 377, in pytest_cmdline_main
    return wrap_session(config, _main)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/_pytest/main.py", line 326, in wrap_session
    config._do_configure()
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1205, in _do_configure
    self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/pluggy/_hooks.py", line 534, in call_historic
    res = self._hookexec(self.name, self._hookimpls.copy(), kwargs, False)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/.venv/lib/python3.12/site-packages/pluggy/_callers.py", line 121, in _multicall
    res = hook_impl.function(*args)
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/rocprof-sys-build/share/rocprofiler-systems/tests/pytest/conftest.py", line 158, in pytest_configure
    header = _generate_config_header_with_timeout()
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/rocprof-sys-build/share/rocprofiler-systems/tests/pytest/conftest.py", line 1370, in _generate_config_header_with_timeout
    return _generate_rocprofsys_config_header()
  File "/home/rocm/rocm-systems-branches/fix-timeout-tests/projects/rocprofiler-systems/rocprof-sys-build/share/rocprofiler-systems/tests/pytest/conftest.py", line 1390, in _generate_rocprofsys_config_header
    time.sleep(_hang_seconds)
======================================================================
```
Which corretly prints out the manual `time.sleep(_hang_seconds)`.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amd-chiranjeevi amd-chiranjeevi amd-chiranjeevi approved these changes

Assignees

No one assigned

Labels

ci:run-all-archs Opt-in to building for all architectures on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kcossett-amd @amd-chiranjeevi