Repository navigation
ci: add no_rocm_image_ubuntu24_04_openmpi test image - #6610
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
1 task done
|
🎉 All checks passed! This PR is ready for review. |
marbre
reviewed
Jul 20, 2026
minseobshin11
added a commit
that referenced
this pull request
Jul 23, 2026
## Motivation rocprofiler-sdk's `rocprofv3` **mpi-ranks** tests are silently **disabled** unless `find_package(MPI)` succeeds at test-configure time. The shared `no_rocm` test image doesn't include an MPI implementation, so these tests never run in CI. This PR points the rocprofiler-sdk test job at the dedicated OpenMPI test image so the tests find MPI and run. ## Technical Details - Points the `rocprofiler-sdk` test job at `ghcr.io/rocm/no_rocm_image_ubuntu24_04_openmpi` via `container_image` in `build_tools/github_actions/fetch_test_configurations.py`. Depends on #6610, which adds and publishes that image. `test_rocprofiler_sdk.py` configures and builds the tests at test time inside the container, so `find_package(MPI)` resolves the system OpenMPI and `mpiexec` is on `PATH`, enabling the mpi-ranks tests. `rocprofv3` itself does not link MPI, so no build-time MPI is required and OpenMPI stays out of the shipped ROCm artifacts. The image is referenced by tag pending publish; it will be pinned to an `@sha256` digest once #<image PR> lands and the image is published (see `dockerfiles/README.md`). ## Test Plan Run the `rocprofiler-sdk` test job in CI on the OpenMPI image and confirm the mpi-ranks tests are selected and executed (not `DISABLED`) and pass. ## Test Result _CI run on this branch: the rocprofiler-sdk job runs on the OpenMPI test image and the mpi-ranks tests run + pass ## JIRA ID JIRA ID : AIROCVAL-45 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Several ROCm subproject tests gate on
find_package(MPI)and launch undermpiexec, but the sharedno_rocmtest image doesn't include an MPI implementation — so those tests are silentlyDISABLEDin CI. OpenMPI is intentionally not bundled in ROCm artifacts (we don't want to force our MPI onto users, who may run their own), so this PR provides it at the system level in a dedicated test image. The first consumer is rocprofiler-sdk'srocprofv3mpi-ranks tests; the test-job wiring lands in a follow-up (#5627).Technical Details
dockerfiles/no_rocm_image_ubuntu24_04_openmpi.Dockerfile, extending the baseno_rocm_image_ubuntu24_04image with a system OpenMPI install (apt install libopenmpi-dev openmpi-bin— Ubuntu 24.04's OpenMPI 4.1.x).publish_no_rocm_image_ubuntu24_04_openmpiin.github/workflows/publish_no_rocm_image_ubuntu24_04.yml(mirrors the_media/_rocgdbextension jobs so it rebuilds when the base image changes).dockerfiles/README.md.Published image:
ghcr.io/rocm/no_rocm_image_ubuntu24_04_openmpi.Test Plan
publish_no_rocm_image_ubuntu24_04.yml(push tomain/stage/docker/**, orworkflow_dispatch) and confirm the image builds and publishes.mpiexeconPATHandfind_package(MPI)succeeds.Test Result
_Image builds and publishes via
publish_no_rocm_image_ubuntu24_04.ymlJIRA ID
JIRA ID : AIROCVAL-45
Submission Checklist