[ci] Adding multi-arch CI ASAN run for submodule bumps

.github/workflows/multi_arch_ci_asan.yml

@@ -25,6 +25,11 @@ on:
         type: string
         default: ""
         description: "Workflow run ID to copy prebuilt stage artifacts from; required when prebuilt_stages is set"
+  pull_request:
+    types:
+      - labeled
+      - opened
+      - synchronize
 
 permissions:
   contents: read
@@ -73,7 +78,7 @@ jobs:
       id-token: write
 
   ci_summary:
-    name: CI Summary
+    name: CI ASAN Summary
     if: always()
     needs:
       - setup
@@ -86,6 +91,4 @@ jobs:
           GITHUB_TOKEN: ${{ github.token }}
         run: |
           python build_tools/github_actions/workflow_summary.py \
-            --workflow-name="${{ github.workflow }}" \
-            --run-id="${{ github.run_id }}" \
-            --run-attempt="${{ github.run_attempt }}"
+            --needs-json '${{ toJSON(needs) }}'

build_tools/github_actions/amdgpu_family_matrix.py

@@ -100,6 +100,7 @@ def select_build_runner(platform: str, build_variant: str) -> str:
             "build_variant_label": "asan",
             "build_variant_suffix": "asan",
             "build_variant_cmake_preset": "linux-release-asan",
+            "expect_failure": True,
         },
         "tsan": {
             "build_variant_label": "tsan",

build_tools/github_actions/configure_multi_arch_ci.py

@@ -501,6 +501,20 @@ def should_skip_ci(
         print("  Skipping: 'ci:skip' PR label")
         return True
 
+    # Skip ASAN on PRs unless submodule changes are present.
+    # This avoids running expensive ASAN builds on every PR while still
+    # catching ASAN issues when library code (submodules) changes.
+    if (
+        ci_inputs.is_pull_request
+        and ci_inputs.build_variant == "asan"
+        and git_context.changed_files is not None
+        and git_context.submodule_paths is not None
+    ):
+        matching = set(git_context.submodule_paths) & set(git_context.changed_files)
+        if not matching:
+            print("  Skipping: ASAN PR without submodule changes")
+            return True
+
     # If we have a list of changed files (push/pull_request events), check if
     # CI should run for that set of changed files. For example: if only .md
     # files are changed, skip CI.

build_tools/github_actions/tests/configure_multi_arch_ci_test.py

@@ -238,6 +238,42 @@ def test_none_changed_files_skips_path_filter(self, mock_filter):
         self.assertFalse(cm.should_skip_ci(inputs, git))
         mock_filter.assert_not_called()
 
+    def test_asan_pr_without_submodule_change_skips(self):
+        """ASAN PR without submodule changes skips CI."""
+        inputs = self._inputs(build_variant="asan", pr_labels=[])
+        git = cm.GitContext(
+            changed_files=["CMakeLists.txt", "build_tools/script.py"],
+            submodule_paths=["rocm-libraries", "rocm-systems"],
+        )
+        self.assertTrue(cm.should_skip_ci(inputs, git))
+
+    def test_asan_pr_with_submodule_change_runs(self):
+        """ASAN PR with submodule changes runs CI."""
+        inputs = self._inputs(build_variant="asan", pr_labels=[])
+        git = cm.GitContext(
+            changed_files=["rocm-libraries", "CMakeLists.txt"],
+            submodule_paths=["rocm-libraries", "rocm-systems"],
+        )
+        self.assertFalse(cm.should_skip_ci(inputs, git))
+
+    def test_asan_non_pr_runs_regardless_of_submodule(self):
+        """ASAN on schedule/push runs regardless of submodule changes."""
+        inputs = self._inputs(event_name="schedule", build_variant="asan")
+        git = cm.GitContext(
+            changed_files=None,
+            submodule_paths=["rocm-libraries"],
+        )
+        self.assertFalse(cm.should_skip_ci(inputs, git))
+
+    def test_release_pr_without_submodule_change_runs(self):
+        """Release variant PR without submodule changes still runs (not skipped)."""
+        inputs = self._inputs(build_variant="release", pr_labels=[])
+        git = cm.GitContext(
+            changed_files=["CMakeLists.txt"],
+            submodule_paths=["rocm-libraries"],
+        )
+        self.assertFalse(cm.should_skip_ci(inputs, git))
+
 
 # ---------------------------------------------------------------------------
 # Step 3: Decide Jobs