Repository navigation
build(rocjitsu): add rocjitsu to therock build system - #4942
Merged
Merged
Conversation
amd-arosa
marked this pull request as draft
April 30, 2026 20:22
amd-arosa
force-pushed
the
users/arosa/rj-ci
branch
from
May 4, 2026 18:02
cd35c26 to
53c9114
Compare
Co-authored-by: Copilot <copilot@github.com>
Move the rocjitsu TheRock wrapper under a new top-level simulation directory, include its artifact group in the compiler-runtime stage, and change its feature group to SIMULATION. Also update the rocjitsu artifact descriptor paths to match the new simulation/rocjitsu staging location. Co-authored-by: Copilot <copilot@github.com>
Move the rocjitsu TheRock wrapper from simulation/ to emulation/, update artifact staging paths, and switch the generated feature group to EMULATION.
Prefer rocm-systems/emulation/rocjitsu when present, and fall back to rocm-systems/experimental/rocjitsu for existing checkouts. Emit a clear configure error if neither source layout is available. Co-authored-by: Copilot <copilot@github.com>
amd-arosa
force-pushed
the
users/arosa/rj-ci
branch
from
May 4, 2026 18:03
53c9114 to
02891cc
Compare
amd-arosa
marked this pull request as ready for review
May 4, 2026 18:03
stellaraccident
approved these changes
May 4, 2026
stellaraccident
left a comment
stellaraccident
left a comment
Collaborator
There was a problem hiding this comment.
If it doesn't regress CI, LGTM.
ScottTodd
reviewed
May 4, 2026
ScottTodd
left a comment
ScottTodd
left a comment
Member
There was a problem hiding this comment.
I'd like to check the Linux build logs for this to see if the new component is enabled by default and if it influences CI builds (e.g. adding binary size, adding build time, causing failures)... but we have a 3h+ queue for new AWS runners: https://github.com/ROCm/TheRock/actions/runs/25334890887/job/74277759247?pr=4942
Member
|
The request here was to wait for the Linux jobs to get scheduled and complete, not just merge without signal... |
Member
|
This broke the build: https://github.com/ROCm/TheRock/actions/runs/25344864053/job/74312073259#step:15:181. Please listen to review feedback next time |
ScottTodd
added a commit
that referenced
this pull request
May 4, 2026
Reverts #4942 Broke the build: https://github.com/ROCm/TheRock/actions/runs/25344864053/job/74312073259#step:15:181 ``` 82/84 Test #82: therock-validate-shared-lib-librocprofv3-list-avail.so ........... Passed 0.05 sec Start 83: therock-validate-shared-lib-librocjitsu.so 83/84 Test #83: therock-validate-shared-lib-librocjitsu.so .......................***Failed 0.03 sec Validating shared library: /__w/TheRock/TheRock/build/emulation/rocjitsu/dist/lib/librocjitsu.soTraceback (most recent call last): File "/__w/TheRock/TheRock/build_tools/validate_shared_library.py", line 27, in <module> main(sys.argv[1:]) File "/__w/TheRock/TheRock/build_tools/validate_shared_library.py", line 23, in main run(args) File "/__w/TheRock/TheRock/build_tools/validate_shared_library.py", line 15, in run so = ctypes.cdll.LoadLibrary(shared_lib) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/python/cp312-cp312/lib/python3.12/ctypes/__init__.py", line 460, in LoadLibrary return self._dlltype(name) ^^^^^^^^^^^^^^^^^^^ File "/opt/python/cp312-cp312/lib/python3.12/ctypes/__init__.py", line 379, in __init__ self._handle = _dlopen(self._name, mode) ^^^^^^^^^^^^^^^^^^^^^^^^^ OSError: /__w/TheRock/TheRock/build/emulation/rocjitsu/dist/lib/librocjitsu.so: undefined symbol: _ZNK8rocjitsu16RegisterLiveness19find_free_sgpr_pairEt Start 84: therock-examples-cpp-sdk-user 84/84 Test #84: therock-examples-cpp-sdk-user .................................... Passed 3.99 sec 99% tests passed, 1 tests failed out of 84 Total Test time (real) = 5.86 sec The following tests FAILED: 83 - therock-validate-shared-lib-librocjitsu.so (Failed) Errors while running CTest Error: Process completed with exit code 8. ```
Member
|
Reverted in #5033 |
Member
We're turning off those AWS runners with #5034 fyi |
Contributor
Author
Sorry, failure caused by ordering. New feature got added between what I tested and now. |
amd-arosa
added a commit
that referenced
this pull request
Jul 27, 2026
## Motivation * Fixes #6418. * Rust is required to build the Mirage emulator UX, see #5730 and #4942. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Integrate rocjitsu (ROCm Just-in-Time Suite) into TheRock's CI build system. rocjitsu is a simulation, virtualization, and instrumentation toolset for AMD GPU applications. It provides ISA-level execution of AMD GPU and RISC-V machine code from HIP fat binaries without requiring GPU hardware. Until now it had only a standalone build and a separate CI workflow in rocm-systems; this PR brings it into the TheRock super-project so it participates in the unified build, artifact distribution, and test infrastructure.
Technical Details
followed https://github.com/ROCm/TheRock/blob/main/docs/development/build_system.md#adding-sub-projects
Test Plan
The CI should run and pass.
Test Result
Worked on my machine.
Submission Checklist