Patch test_components fromJSON error when test_runs_on is empty#4930
Merged
Conversation
When configure_test_matrix is skipped (test_runs_on is empty), its
components output is an empty string. The existing guard only checked
for '[]', so empty string passed the if condition and fromJSON('')
failed with "empty input".
This was exposed by PR #4911 which calls test_artifacts.yml from
release workflows for all families, including those without test
runners (gfx900, gfx906, gfx908, gfx101x, etc.).
Changes:
- Add != '' guard so test_components is skipped when
configure_test_matrix was skipped
- Add || '[]' fallback in fromJSON for defense in depth
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
geomin12
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This dev release in rockrel: https://github.com/ROCm/rockrel/actions/runs/25100364100/attempts/1 hit errors
Multi-Arch Release Error when evaluating 'strategy' for job 'test_components'. ROCm/TheRock/.github/workflows/test_artifacts.yml@30fc752307885b3099b9a25b2fde039928d8a651 (Line: 176, Col: 21): Error from function 'fromJSON': empty input, ROCm/TheRock/.github/workflows/test_artifacts.yml@30fc752307885b3099b9a25b2fde039928d8a651 (Line: 176, Col: 21): Unexpected value ''Technical Details
I think we missed this in CI workflows since multi_arch_ci_linux.yml has a
expect_failurecondition:TheRock/.github/workflows/multi_arch_ci_linux.yml
Lines 99 to 103 in 88425ee
I did not add that condition to multi_arch_release_linux.yml:
TheRock/.github/workflows/multi_arch_release_linux.yml
Lines 117 to 120 in 7161bc7
I'd like to remove that
expect_failureentirely since it isn't actually working right now in multi-arch CI, see #4500Test Plan
We'll need to run a release workflow until it reaches the test step, which takes hours. Might as well merge and test via an actual dev release.
Submission Checklist