-
Notifications
You must be signed in to change notification settings - Fork 294
Update Ubuntu dependencies in documentation #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,14 +21,16 @@ Currently, the platform offers developers the option to build HIP and ROCm from | |||||
| ### Ubuntu | ||||||
|
|
||||||
| ```bash | ||||||
| # Install Ubuntu dependencies | ||||||
| sudo apt install gfortran git git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake python3-venv python3-dev libegl1-mesa-dev | ||||||
|
|
||||||
| # Clone the repository | ||||||
| git clone https://github.com/ROCm/TheRock.git | ||||||
| cd TheRock | ||||||
|
|
||||||
| # Install dependencies | ||||||
| # Init python virtual environment and install python dependencies | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT:
Suggested change
|
||||||
| python3 -m venv .venv && source .venv/bin/activate | ||||||
| pip install -r requirements.txt | ||||||
| sudo apt install gfortran git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake | ||||||
| python ./build_tools/fetch_sources.py # Downloads submodules and applies patches | ||||||
| ``` | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git-lfsalready pulls ingitthus we can add it to the list but could also omit if we want to keep the list shorter.