Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,16 @@ Currently, the platform offers developers the option to build HIP and ROCm from
### Ubuntu

```bash
# Install Ubuntu dependencies
sudo apt install gfortran git git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake python3-venv python3-dev libegl1-mesa-dev

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo apt install gfortran git git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake python3-venv python3-dev libegl1-mesa-dev
sudo apt install gfortran git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake python3-venv python3-dev libegl1-mesa-dev

git-lfs already pulls in git thus we can add it to the list but could also omit if we want to keep the list shorter.


# Clone the repository
git clone https://github.com/ROCm/TheRock.git
cd TheRock

# Install dependencies
# Init python virtual environment and install python dependencies

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:

Suggested change
# Init python virtual environment and install python dependencies
# Init Python virtual environment and install Python dependencies

python3 -m venv .venv && source .venv/bin/activate
pip install -r requirements.txt
sudo apt install gfortran git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake
python ./build_tools/fetch_sources.py # Downloads submodules and applies patches
```

Expand Down