Repository navigation
[ci] enabling all archs for nightly tests - #4616
Merged
Merged
Conversation
ScottTodd
reviewed
Apr 16, 2026
Comment on lines
+773
to
+783
| self.assertIsNotNone(result.linux) | ||
| entry = result.linux.per_family_info[0] | ||
| self.assertEqual(entry["test-runs-on"], "linux-strix-halo-gpu-rocm-oem") | ||
| self.assertEqual(entry["test-runs-on"], "") |
Member
There was a problem hiding this comment.
This change defeats the purpose of the test. Rework?
Contributor
Author
There was a problem hiding this comment.
actually, the nightly run flag will disable it for all scenarios except scheduled runs. I guess the developers using these machines just invoke the label directly, so this test should be good to remove.
once we get all the capacity back for linux gfx1151, we can re-enable this PR label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned, we are enabling all archs for nightly test runs to determine what is missing and fixing tests