Skip to content

[ci] Prune test_type / test_labels from build jobs#4503

Merged
ScottTodd merged 1 commit into
ROCm:mainfrom
ScottTodd:workflow-inputs-prune
Apr 14, 2026
Merged

[ci] Prune test_type / test_labels from build jobs#4503
ScottTodd merged 1 commit into
ROCm:mainfrom
ScottTodd:workflow-inputs-prune

Conversation

@ScottTodd
Copy link
Copy Markdown
Member

Motivation

These inputs are unused and do not belong in build jobs. Removing them will help with:

Technical Details

These other inputs are also candidates for cleanup:

input notes
expect_failure See #4500
artifact_group Previously used here, may need to line up with build_variant_suffix:
- name: Post Build Upload
if: always()
run: |
python3 build_tools/github_actions/post_build_upload.py \
--run-id ${{ github.run_id }} \
--artifact-group "${{ inputs.artifact_group }}" \
build_variant_label Previously used here, may be useful later:
runs-on: ${{ (contains(inputs.build_variant_label, 'asan') || contains(inputs.build_variant_label, 'tsan')) && 'azure-linux-scale-rocm-heavy-ramdisk' || 'azure-linux-scale-rocm' }}
(but see also #4415)
build_variant_suffix Partially handled:
suffix = variant_config.get("build_variant_suffix", "")
return BuildConfig(
per_family_info=per_family_info,
dist_amdgpu_families=";".join(family_names),
artifact_group=f"multi-arch-{suffix or 'release'}",
build_variant_label=variant_config["build_variant_label"],
build_variant_suffix=suffix,
build_python_packages:
needs: [build_multi_arch_stages]
name: Build Python Packages
if: ${{ !failure() && !cancelled() && fromJSON(inputs.build_config).expect_failure == false }}
uses: ./.github/workflows/build_portable_linux_python_packages.yml
with:
artifact_group: ${{ fromJSON(inputs.build_config).artifact_group }}

Test Plan

  • CI run should include expected build/test jobs

Submission Checklist

@ScottTodd ScottTodd marked this pull request as ready for review April 13, 2026 22:55
@ScottTodd ScottTodd requested a review from geomin12 April 13, 2026 22:55
Copy link
Copy Markdown
Contributor

@geomin12 geomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ScottTodd ScottTodd merged commit 9f8fcb5 into ROCm:main Apr 14, 2026
120 of 127 checks passed
@ScottTodd ScottTodd deleted the workflow-inputs-prune branch April 14, 2026 15:20
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants