fix(ocl) - Install ocltst files to bin dir, ocltst libs to paths according to OS by agunashe · Pull Request #4305 · ROCm/TheRock

agunashe · 2026-04-02T00:18:28Z

Motivation

Windows -

Install ocltst binary to bin directory.
Windows users can execute it directly without having to copy dlls

Linux -

Install ocltst libs to lib directory.
Windows users can execute it directly without having to copy dlls
OpenCl lib dependency will be fullfiled by distro package and not from Rock

Requires ocltst installation to bin directory in rocm-system PR
ROCm/rocm-systems#4632 - originally merged but was reverted becasue of missing Opencl dependencies in the libs. Opencl will be provided by distro package
ROCm/rocm-systems#9804 - new PR to install the files in the right folder.

This rock PR should independently succeed without changes from rocm-systems. Only rocm-systems PR9804 depends on this PR

ISSUE ID: #4192

Test Plan

ocl_test package should have all files required to execute the tests

Test Result

ocl_test to have the required files

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

…_path

Copilot

Pull request overview

Adjusts the core-ocl artifact packaging rules to align which OpenCL CLR outputs get shipped in the run vs test components.

Changes:

Narrow components.run contents from all bin/** to just bin/clinfo.
Narrow components.test contents from tests/** and share/opencl/** to just bin/ocltst.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…_path

includes rpath to opencl build

…_path

remove opencl checks in sharedLib tests since we are shipping it as of now

…_path

ScottTodd

Generally LGTM. Let's get ROCm/rocm-systems#4632 landed and pulled in so we can drop the rocm-systems submodule change from this PR before merge

ScottTodd · 2026-04-13T17:10:04Z

+  "bin/*oclruntime*",
+  "lib/*oclgl*",
+  "lib/*oclperf*",
+  "lib/*oclruntime*",


I pulled down the artifacts to test this:

D:\projects\TheRock (main -> upstream) (.venv) λ python build_tools/artifact_manager.py fetch ^ --run-id=24252731459 ^ --stage=all ^ --flatten ^ --amdgpu-families=gfx110X-all ^ --output-dir=D:/scratch/therock/24252731459/

Do you want to put oclruntime.dll in bin/ on Windows? That would more closely match other subprojects:

>>> paths = list(Path.cwd().glob("bin/*ocl*")) + list(Path.cwd().glob("lib/*ocl*")) >>> for path in paths: ... print(path) ... D:\scratch\therock\24252731459\bin\amdocl64.dll D:\scratch\therock\24252731459\bin\oclperf.exclude D:\scratch\therock\24252731459\bin\oclruntime.exclude D:\scratch\therock\24252731459\bin\ocltst.exe D:\scratch\therock\24252731459\lib\amdocl64.lib D:\scratch\therock\24252731459\lib\oclperf.dll D:\scratch\therock\24252731459\lib\oclperf.lib D:\scratch\therock\24252731459\lib\oclruntime.dll D:\scratch\therock\24252731459\lib\oclruntime.lib

I was able to run ocltst with the DLL in lib, just a bit awkward:

λ .\ocltst -m ..\lib\oclruntime.dll -A oclruntime.exclude Compute Device info: Platform Version: OpenCL 2.1 AMD-APP (3652.0) Device Name: gfx1100 Vendor: Advanced Micro Devices, Inc. Device Version: OpenCL 2.0 AMD-APP (3652.0) Driver Version: 3652.0 (PAL,LC) Board Name: AMD Radeon PRO W7900 Dual Slot ------------------------------------------------- The OpenCL Testing Module oclruntime Version = 0 ------------------------------------------------- OCLCreateContext[ 0] PASSED: GPU[0] T[0] [ 0], 0.000 OCLKernelBinary[ 0] PASSED: GPU[0] T[0] [ 0], 0.000

sure thanks. fixed this in the latest commit of rocm-systems PR.
Listing the contents of ocl_test package.

Linux

Windows

if you approve this, I can merge the rocm-systems and wait for rocm-systems bump for this PR.
Parallelly can work on fixing the ocltst PR to pick these new path changes
#3590

The code changes LGTM. Need to merge the rocm-systems PR first and pull that in during a regular submodule update. I'm not going to approve until the submodule update is separate from this PR (we're hemorrhaging on submodule updates lately due to infra issues, build failures, and test failures, and I don't want to risk an unscheduled update slipping through without going through the standard process)

sure thanks. I merged ROCm/rocm-systems#4632 into rocm-systems.
Will drop rocm-systems from this PR and wait for the rocm-systems bump.

@ScottTodd - I had to revert ROCm/rocm-systems#4632 because of missing OpenCL.so dependency with liboclperf.so, liboclruntime.so. Opencl.so dependency is satisfied by ubuntu packages ocl-icd-libopencl1, ocl-icd-opencl-dev. This PR skips checking the ldd for these test libs.

New rocm-systems PR - ROCm/rocm-systems#9804
Once you approve , I need to rebase and drop rocm-systems in this PR.
rocm-systems PR depends on this rock PR. So this needs to go in first.

for the folder structure of test files please see below screenshots

Linux
https://therock-ci-artifacts.s3.amazonaws.com/33570960219-linux/core-ocl_test_generic.tar.zst

windows
https://therock-ci-artifacts.s3.amazonaws.com/33570960219-windows/core-ocl_test_generic.tar.zst

SGTM, will take a look at the new PR.

I see you approved https://github.com/ROCm/rocm-systems/pull/9804/changes. Will drop rocm-systems in this PR and rebase this. So we can merge this next week

@ScottTodd - I dropped rocm-systems from this PR and its rebased. All required tests have passed.
Can you help approve this PR please.

https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md#responding-to-review-feedback-and-re-requesting-review

therock-pr-bot · 2026-08-11T18:05:33Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-08-11T18:05:36Z

🎉 All checks passed! This PR is ready for review.

…_path

…ocltst_path r-s in this PR will be dropped after the testing is complete

…_path

ScottTodd · 2026-10-07T15:32:40Z

Windows tests on presubmit were switched to opt-in last week with #8710 due to 48h+ runner queues. I added the opt-in label so we can see test results there :/. Could also trigger the test workflow directly.

ScottTodd

CI results look complete enough now

…libs to lib dir (#9804) ## Motivation Install ocltst to bin folder for both linux and windows The ocltst libraries need to be installed to bin - on windows lib - on linux ROCm/TheRock#4192 Install ocltst to bin folder for both linux and windows align to packaging requirement. Install ocltst to bin folder for both linux and windows. On windows, this helps to test the runtime libraries without having to do extra copies or setup ## Technical Details Install ocltst to bin folder for both linux and windows The ocltst libraries need to be installed to bin - on windows lib - on linux same change was merged before - #4632 but had to be reverted because of missing Opencl.so issue. Revert commit - 90792ab testing this change in Rock - ROCm/TheRock#4305 ## Issue Tracking    ROCm/TheRock#4192 ## Test Plan Rock build passes testing this change in Rock - ROCm/TheRock#4305 ## Test Result Rock build passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ocl test libs to lib dir (#9804) ## Motivation Install ocltst to bin folder for both linux and windows The ocltst libraries need to be installed to bin - on windows lib - on linux ROCm/TheRock#4192 Install ocltst to bin folder for both linux and windows align to packaging requirement. Install ocltst to bin folder for both linux and windows. On windows, this helps to test the runtime libraries without having to do extra copies or setup ## Technical Details Install ocltst to bin folder for both linux and windows The ocltst libraries need to be installed to bin - on windows lib - on linux same change was merged before - ROCm/rocm-systems#4632 but had to be reverted because of missing Opencl.so issue. Revert commit - ROCm/rocm-systems@90792ab testing this change in Rock - ROCm/TheRock#4305 ## Issue Tracking    ROCm/TheRock#4192 ## Test Plan Rock build passes testing this change in Rock - ROCm/TheRock#4305 ## Test Result Rock build passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#9804 (commit 7054b96)

…libs to lib dir (#9804) ## Motivation Install ocltst to bin folder for both linux and windows The ocltst libraries need to be installed to bin - on windows lib - on linux ROCm/TheRock#4192 Install ocltst to bin folder for both linux and windows align to packaging requirement. Install ocltst to bin folder for both linux and windows. On windows, this helps to test the runtime libraries without having to do extra copies or setup ## Technical Details Install ocltst to bin folder for both linux and windows The ocltst libraries need to be installed to bin - on windows lib - on linux same change was merged before - #4632 but had to be reverted because of missing Opencl.so issue. Revert commit - 90792ab testing this change in Rock - ROCm/TheRock#4305 ## Issue Tracking    ROCm/TheRock#4192 ## Test Plan Rock build passes testing this change in Rock - ROCm/TheRock#4305 ## Test Result Rock build passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

artifacts: ocltst files from bin

758566e

github-project-automation Bot added this to TheRock Triage Apr 2, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Apr 2, 2026

agunashe marked this pull request as draft April 2, 2026 00:18

agunashe added 3 commits April 2, 2026 14:55

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

9480530

…_path

Install ocltst to bin dir

8f630da

reenable hip-tests build

a7acb83

agunashe changed the title ~~artifacts: ocltst files from bin~~ install ocltst files to bin dir Apr 2, 2026

agunashe requested a review from Copilot April 2, 2026 21:30

Copilot started reviewing on behalf of agunashe April 2, 2026 21:32

View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Comment thread core/artifact-core-ocl.toml Resolved

Comment thread core/artifact-core-ocl.toml Resolved

Comment thread core/artifact-core-ocl.toml Resolved

agunashe and others added 2 commits April 2, 2026 14:43

Apply suggestions from code review

ee44cfd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

move ocltst related files to test package

74f64e2

agunashe changed the title ~~install ocltst files to bin dir~~ Install ocltst files to bin dir Apr 3, 2026

agunashe and others added 13 commits April 3, 2026 00:59

keep the ocltst libs/dlls in ocl_test package

a2b9917

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

6d2ca20

…_path

add ocltst build section for windows

d3509ff

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

086a32c

…_path

use users/agunashe/ocltst_install 829a626

6de7fb4

includes rpath to opencl build

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

a19b01c

…_path

add ocl-icd to python packages

d03d3ec

remove opencl checks in sharedLib tests since we are shipping it as of now

group the ocltst files together correctly

992f789

include exclude files in ocltest

8aa522f

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

075d5fe

…_path

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

ee36f9e

…_path

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

51b6b95

…_path

update rocm-systems to pick rebased users/agunashe/ocltst_install

338643d

agunashe marked this pull request as ready for review April 13, 2026 16:53

agunashe requested a review from a team as a code owner April 13, 2026 16:53

ScottTodd reviewed Apr 13, 2026

View reviewed changes

agunashe requested a review from marbre as a code owner August 11, 2026 18:05

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 11, 2026

agunashe added 2 commits August 11, 2026 11:07

build ocltests for linux for now

32e1744

fix some formatting issues

6485c40

agunashe changed the title ~~Install ocltst files to bin dir~~ Install ocltst files to bin dir and ocltst libs to paths according to OS Aug 11, 2026

therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 11, 2026

fix the duplicate sections in ocl.toml file

9879622

agunashe changed the title ~~Install ocltst files to bin dir and ocltst libs to paths according to OS~~ fix(ocl) - Install ocltst files to bin dir, ocltst libs to paths according to OS Aug 11, 2026

agunashe and others added 4 commits August 26, 2026 15:14

Merge branch 'main' into users/agunashe/ocltst_path

263877e

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

505c706

…_path

add oclgl lib to exception list, add a8b0fac from r-s users/agunashe/…

4b2c7d1

…ocltst_path r-s in this PR will be dropped after the testing is complete

build ocltst on windows as well

aad601a

agunashe mentioned this pull request Oct 2, 2026

fix ocltst paths. Windows: ocl test libs to bin dir, Linux: ocl test libs to lib dir ROCm/rocm-systems#9804

Merged

1 task done

agunashe and others added 4 commits October 2, 2026 13:38

Merge remote-tracking branch 'origin/main' into users/agunashe/ocltst…

09354d4

…_path

Merge branch 'main' into users/agunashe/ocltst_path

bf38584

pick share/opencl/** as part of tests to pass Rock

2a34041

Merge branch 'main' into users/agunashe/ocltst_path

e25b8e4

ScottTodd self-requested a review October 6, 2026 23:13

ScottTodd mentioned this pull request Oct 7, 2026

[ci] Gate gfx110X Windows presubmit tests behind a label #8710

Merged

1 task done

ScottTodd added the ci:test:gfx110x Opt-in to gfx110x tests only (requires build) label Oct 7, 2026

ScottTodd approved these changes Oct 7, 2026

View reviewed changes

agunashe merged commit e2b34ee into main Oct 7, 2026
329 of 338 checks passed

agunashe deleted the users/agunashe/ocltst_path branch October 7, 2026 18:32

agunashe mentioned this pull request Oct 7, 2026

Testing ocltst paths , PR from rocm-systems #7172

Closed

1 task done

Conversation

agunashe commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Test Plan

Test Result

Submission Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ScottTodd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

therock-pr-bot Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ScottTodd commented Oct 7, 2026

Uh oh!

ScottTodd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

agunashe commented Apr 2, 2026 •

edited

Loading

therock-pr-bot Bot commented Aug 11, 2026 •

edited

Loading

therock-pr-bot Bot commented Aug 11, 2026 •

edited

Loading